From 69fe535462ce1d10dee43736d83c621031ff4ea2 Mon Sep 17 00:00:00 2001 From: Zachary Hirsch Date: Sat, 30 Sep 2017 19:15:13 -0400 Subject: [PATCH 1/2] Fix currentpage parameter: it should be in the query, not the path. --- openapi-2.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/openapi-2.json b/openapi-2.json index ee5ed2b..cc6e0d8 100644 --- a/openapi-2.json +++ b/openapi-2.json @@ -2251,7 +2251,7 @@ "parameters": [ { "name": "currentpage", - "in": "path", + "in": "query", "description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.", "required": true, "type": "integer", @@ -2331,7 +2331,7 @@ "parameters": [ { "name": "currentpage", - "in": "path", + "in": "query", "description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.", "required": true, "type": "integer", @@ -2741,7 +2741,7 @@ "parameters": [ { "name": "currentpage", - "in": "path", + "in": "query", "description": "Page number (starting with 1). Each page has a fixed size of 50 entries.", "required": true, "type": "integer", @@ -2958,7 +2958,7 @@ "parameters": [ { "name": "currentpage", - "in": "path", + "in": "query", "description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.", "required": true, "type": "integer", @@ -3024,7 +3024,7 @@ "parameters": [ { "name": "currentpage", - "in": "path", + "in": "query", "description": "Page number (starting with 1). Each page has a fixed size of 50 items per page.", "required": true, "type": "integer", From 6f2f3b9c995f59cd59f85f845f36e34b068e236f Mon Sep 17 00:00:00 2001 From: Zachary Hirsch Date: Sat, 30 Sep 2017 19:15:58 -0400 Subject: [PATCH 2/2] Fix components parameter: OpenAPI 2.0 does not allow $ref in query parameters. --- openapi-2.json | 40 ++++++++++++++++++++++++---------------- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/openapi-2.json b/openapi-2.json index cc6e0d8..ad2b9a3 100644 --- a/openapi-2.json +++ b/openapi-2.json @@ -3935,8 +3935,9 @@ "description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.", "type": "array", "items": { - "$ref": "#/definitions/Destiny.DestinyComponentType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "destinyMembershipId", @@ -4020,8 +4021,9 @@ "description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.", "type": "array", "items": { - "$ref": "#/definitions/Destiny.DestinyComponentType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "destinyMembershipId", @@ -4148,8 +4150,9 @@ "description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.", "type": "array", "items": { - "$ref": "#/definitions/Destiny.DestinyComponentType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "destinyMembershipId", @@ -4242,8 +4245,9 @@ "description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.", "type": "array", "items": { - "$ref": "#/definitions/Destiny.DestinyComponentType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "destinyMembershipId", @@ -4332,8 +4336,9 @@ "description": "A comma separated list of components to return (as strings or numeric values). See the DestinyComponentType enum for valid components to request. You must request at least one component to receive results.", "type": "array", "items": { - "$ref": "#/definitions/Destiny.DestinyComponentType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "destinyMembershipId", @@ -5252,8 +5257,9 @@ "description": "Group of stats to include, otherwise only general stats are returned. Comma separated list is allowed. Values: General, Weapons, Medals", "type": "array", "items": { - "$ref": "#/definitions/Destiny.HistoricalStats.Definitions.DestinyStatsGroupType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "membershipType", @@ -5278,8 +5284,9 @@ "description": "Game modes to return. See the documentation for DestinyActivityModeType for valid values, and pass in string representation, comma delimited.", "type": "array", "items": { - "$ref": "#/definitions/Destiny.HistoricalStats.Definitions.DestinyActivityModeType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "periodType", @@ -5356,8 +5363,9 @@ "description": "Groups of stats to include, otherwise only general stats are returned. Comma separated list is allowed. Values: General, Weapons, Medals.", "type": "array", "items": { - "$ref": "#/definitions/Destiny.HistoricalStats.Definitions.DestinyStatsGroupType" - } + "type": "integer" + }, + "collectionFormat": "csv" }, { "name": "membershipType",