Skip to content

Commit fa84a83

Browse files
authored
Merge pull request #123 from ozanerturk/master
fix for issue : https://github.com/CacheControl/json-rules-engine/iss…
2 parents 5ac00ea + 1e875d9 commit fa84a83

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

src/engine.js

+1
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ class Engine extends EventEmitter {
6666

6767
let index = this.rules.indexOf(rule)
6868
if (index === -1) return false
69+
this.prioritizedRules = null
6970
return Boolean(this.rules.splice(index, 1).length)
7071
}
7172

test/engine.test.js

+9
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ describe('Engine', () => {
8989
expect(engine.rules.length).to.equal(1)
9090
engine.removeRule(rule)
9191
expect(engine.rules.length).to.equal(0)
92+
expect(engine.prioritizedRules).to.equal(null)
9293
})
9394
})
9495

@@ -106,6 +107,14 @@ describe('Engine', () => {
106107
const isRemoved = engine.removeRule(rule)
107108
expect(isRemoved).to.equal(false)
108109
})
110+
111+
it('clears the "prioritizedRules" cache', () => {
112+
let rule = new Rule(factories.rule())
113+
engine.addRule(rule)
114+
engine.prioritizeRules()
115+
engine.removeRule(rule)
116+
expect(engine.prioritizedRules).to.equal(null)
117+
})
109118
})
110119

111120
describe('addOperator()', () => {

0 commit comments

Comments
 (0)