Fix TypeScript server

Bug: none
Change-Id: I1e6018e5df660afa6e7b0075139d678395984a68
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6549407
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>

Author: Lightning00Blade

front_end/tsconfig.json

@@ -2,6 +2,18 @@
   "extends": "../config/typescript/tsconfig.base.json",
   "compilerOptions": {
     "allowUmdGlobalAccess": true,
-    "outDir": "ignored"
+    "outDir": "ignored",
+    "lib": ["esnext", "dom", "dom.iterable", "webworker", "webworker.iterable"],
+    "plugins": [
+      {
+        "name": "ts-lit-plugin",
+        "rules": {
+          "no-complex-attribute-binding": "off",
+          "no-missing-import": "error",
+          "no-unknown-tag-name": "error",
+          "no-unclosed-tag": "error"
+        }
+      }
+    ]
   }
 }

scripts/devtools_paths.js

@@ -157,7 +157,7 @@ function litAnalyzerExecutablePath() {
  * @returns the path to the toplevel `tsconfig.json`.
  */
 function tsconfigJsonPath() {
-  return path.join(devtoolsRootPath(), 'tsconfig.json');
+  return path.join(devtoolsRootPath(), 'front_end', 'tsconfig.json');
 }
 
 function downloadedChromeBinaryPath() {

scripts/test/run_lint_check.mjs

@@ -32,9 +32,10 @@ const flags = yargs(hideBin(process.argv))
       'Disable cache validations during debugging, useful for custom rule creation/debugging.',
   })
   .usage('$0 [<files...>]', 'Run the linter on the provided files', yargs => {
-    yargs.positional('files', {
+    return yargs.positional('files', {
       describe: 'File(s), glob(s), or directories',
-      type: 'array',
+      type: 'string',
+      array: true,
       default: [
         'front_end',
         'inspector_overlay',

test/conductor/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.test.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "baseUrl": "."
   }

test/e2e/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.test.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "baseUrl": "."
   },

test/e2e_non_hosted/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.test.json",
+  "extends": "../tsconfig.json",
   "references": [
     {
       "path": "../shared/tsconfig.json"

test/interactions/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.test.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "baseUrl": "."
   },

test/perf/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.test.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "baseUrl": "."
   },

test/run.ts

@@ -55,7 +55,7 @@ function forwardOptions(): string[] {
 
   // @ts-expect-error yargs and unparse have slightly different types
   const unparsed = unparse(forwardedOptions);
-  const args = [];
+  const args: string[] = [];
   for (let i = 0; i < unparsed.length - 1; i++) {
     if (unparsed[i].startsWith('--') && !Number.isNaN(Number(unparsed[i + 1]))) {
       // Mocha errors on --repeat 1 as it expects --repeat=1. We assume

test/shared/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.test.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "baseUrl": "."
   },

test/tsconfig.test.json renamed to test/tsconfig.json

@@ -1,14 +1,14 @@
 {
-  "extends": "../tsconfig.test.json",
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "baseUrl": "."
   },
   "references": [
     {
-      "path": "../conductor"
+      "path": "../conductor/tsconfig.json"
     },
     {
-      "path": "../shared"
+      "path": "../shared/tsconfig.json"
     }
   ]
 }