Skip to content

Commit 70537a4

Browse files
authored
Start validating version in CI (#18077)
* Start validating version in CI * Fix changelogs and ignore ddev
1 parent 1f0af38 commit 70537a4

File tree

50 files changed

+267
-61
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+267
-61
lines changed

.github/workflows/run-validations.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,10 @@ on:
102102
required: false
103103
default: false
104104
type: boolean
105+
version:
106+
required: false
107+
default: false
108+
type: boolean
105109

106110
defaults:
107111
run:
@@ -231,6 +235,10 @@ jobs:
231235
if: inputs.labeler
232236
run: ddev validate labeler
233237

238+
- name: Validate target version
239+
if: inputs.version
240+
run: ddev validate version $TARGET
241+
234242
# Every validation below here is sorted by increasing runtime rather than alphabetically
235243
- name: Validate third-party license metadata
236244
if: inputs.licenses

.github/workflows/validate.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,5 @@ jobs:
3838
readmes: true
3939
saved-views: true
4040
service-checks: true
41+
version: true
4142
secrets: inherit

agent_metrics/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Agent Metrics
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

amazon_eks/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Amazon EKS
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

amazon_eks_blueprints/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - amazon_eks_blueprints
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

azure_active_directory/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Azure Active Directory
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

cisco_duo/CHANGELOG.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
# CHANGELOG - cisco_duo
22

3-
<!-- towncrier release notes start -->
4-
53
## 1.0.0 / 2024-01-31
64

75
***Added***:
86

9-
* Initial Release
7+
* Initial Release

cisco_sdwan/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
# CHANGELOG - Cisco SD-WAN
22

3-
<!-- towncrier release notes start -->
43

4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

cisco_umbrella_dns/CHANGELOG.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
# CHANGELOG - cisco_umbrella_dns
22

3-
<!-- towncrier release notes start -->
4-
5-
1.0.0 / 2024-01-01
3+
## 1.0.0 / 2024-01-01
64

75
***Added***:
86

consul_connect/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Consul Connect
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

container/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Container
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

containerd/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Containerd
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

cri/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - CRI
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

databricks/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Databricks
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

datadog_operator/CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# CHANGELOG - Datadog Operator
22

3-
<!-- towncrier release notes start -->
4-
53
## 1.0.0 / 2023-03-30
64

75
***Added***:

ddev/src/ddev/cli/validate/version.py

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,14 @@ def version(ctx: click.Context, integrations: tuple[str, ...]):
112112
if not integrations:
113113
integrations = ('all',)
114114

115-
for current_check in app.repo.integrations.iter_all(selection=integrations):
116-
changelog = current_check.path / 'CHANGELOG.md'
117-
version_file = current_check.package_directory / '__about__.py'
115+
for project in app.repo.integrations.iter_all(selection=integrations):
116+
# ddev manages its version dynamically.
117+
if project.name == 'ddev':
118+
continue
119+
changelog = project.path / 'CHANGELOG.md'
120+
version_file = project.package_directory / ('_version.py' if project.name == 'ddev' else '__about__.py')
118121
is_python_pkg = version_file.exists()
119-
track_err = partial(tracker.error, (current_check.name,))
122+
track_err = partial(tracker.error, (project.name,))
120123

121124
if is_python_pkg and not changelog.exists():
122125
track_err(message=f'This looks like a Python package, but {changelog.relative_to(repo_path)} is missing.')
@@ -126,12 +129,14 @@ def version(ctx: click.Context, integrations: tuple[str, ...]):
126129

127130
if is_python_pkg:
128131
validate = _validate_python_package
129-
else:
132+
elif project.is_tile:
130133
validate = _validate_tile_only_int
134+
else:
135+
continue
131136
validate(
132137
track_err,
133138
repo_path,
134-
current_check,
139+
project,
135140
version_file,
136141
changelog,
137142
changelog_is_autogenerated,

docker_daemon/CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# CHANGELOG - docker_daemon
22

3-
<!-- towncrier release notes start -->
4-
53
## 1.12.0 / 2020-01-13
64

75
***Added***:

eks_anywhere/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Amazon EKS Anywhere
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

gke/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Google Kubernetes Engine
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

go-metro/CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# CHANGELOG - go-metro
22

3-
<!-- towncrier release notes start -->
4-
53
## 1.3.1 / 2021-03-07
64

75
***Fixed***:

helm/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Helm
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

iam_access_analyzer/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Iam Access Analyzer
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

jmeter/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - JMeter
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

kubernetes/CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# CHANGELOG - kubernetes
22

3-
<!-- towncrier release notes start -->
4-
53
## 1.7.0 / 2020-05-17
64

75
***Added***:

kubernetes_state_core/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Kubernetes State Core
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

ntp/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - NTP
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

nvidia_jetson/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Nvidia Jetson
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

oke/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Oracle Container Engine for Kubernetes - OKE
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

oom_kill/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - OOM Kill
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

openai/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - OpenAI
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

openshift/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - OpenShift
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

otel/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - OTel
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

pivotal_pks/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Pivotal PKS
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

podman/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# CHANGELOG - Podman
22

3-
<!-- towncrier release notes start -->
3+
4+
## 1.0.0
5+
6+
***Added***:
7+
8+
* Initial release.

0 commit comments

Comments
 (0)