Skip to content

Commit 204008a

Browse files
TheMostDiligentLadySerenaKitty
authored andcommitted
Disabled format validations on platforms that don't have format validation script
1 parent ede75ed commit 204008a

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

BuildTools/CMake/BuildUtils.cmake

+13-11
Original file line numberDiff line numberDiff line change
@@ -401,20 +401,22 @@ function(add_format_validation_target MODULE_NAME MODULE_ROOT_PATH IDE_FOLDER)
401401
set(RUN_VALIDATION_SCRIPT ./validate_format_freebsd.sh)
402402
elseif(CMAKE_HOST_SYSTEM_NAME STREQUAL "Darwin")
403403
set(RUN_VALIDATION_SCRIPT ./validate_format_mac.sh)
404-
else()
405-
message(FATAL_ERROR "Unexpected host system")
406404
endif()
407405

408-
# Run the format validation script
409-
add_custom_command(TARGET ${MODULE_NAME}-ValidateFormatting
410-
COMMAND ${RUN_VALIDATION_SCRIPT}
411-
WORKING_DIRECTORY "${MODULE_ROOT_PATH}/BuildTools/FormatValidation"
412-
COMMENT "Validating ${MODULE_NAME} module's source code formatting..."
413-
VERBATIM
414-
)
406+
if (RUN_VALIDATION_SCRIPT)
407+
# Run the format validation script
408+
add_custom_command(TARGET ${MODULE_NAME}-ValidateFormatting
409+
COMMAND ${RUN_VALIDATION_SCRIPT}
410+
WORKING_DIRECTORY "${MODULE_ROOT_PATH}/BuildTools/FormatValidation"
411+
COMMENT "Validating ${MODULE_NAME} module's source code formatting..."
412+
VERBATIM
413+
)
415414

416-
if(TARGET ${MODULE_NAME}-ValidateFormatting)
417-
set_target_properties(${MODULE_NAME}-ValidateFormatting PROPERTIES FOLDER ${IDE_FOLDER})
415+
if(TARGET ${MODULE_NAME}-ValidateFormatting)
416+
set_target_properties(${MODULE_NAME}-ValidateFormatting PROPERTIES FOLDER ${IDE_FOLDER})
417+
endif()
418+
else()
419+
message(DEBUG "${MODULE_NAME}-ValidateFormatting target will be disabled because format validation script is not available on ${CMAKE_HOST_SYSTEM_NAME} host platform.")
418420
endif()
419421

420422
endfunction()

0 commit comments

Comments
 (0)