Skip to content

Commit 418a9cc

Browse files
committed
Misc logging tidy
- Removed leftover debug System.out.println in ASM - Removed unused logger from Share - Routed ResourceUtil errors into FPLog instead of System.out/System.err
1 parent 722a08d commit 418a9cc

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

src/main/java/com/falsepattern/lib/internal/Share.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535

3636
@NoArgsConstructor(access = AccessLevel.PRIVATE)
3737
public final class Share {
38-
public static final Logger LOG = LogManager.getLogger(Tags.MODNAME);
39-
4038
public static final boolean DEV_ENV;
4139

4240
static {
@@ -49,8 +47,4 @@ public final class Share {
4947
}
5048

5149
public static boolean EARLY_INIT_DONE = false;
52-
53-
public static void deprecatedWarning(Throwable stacktrace) {
54-
LOG.warn("DEPRECATED API CALLED!", stacktrace);
55-
}
5650
}

src/main/java/com/falsepattern/lib/internal/impl/optifine/OptiFineTransformerHooksImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ public static void init() {
5555
}
5656
for (int i = 0; i < transformers.size(); i++) {
5757
val transformer = transformers.get(i);
58-
System.out.println(transformer.getClass().getName());
5958
if (transformer.getClass().getName().equals("optifine.OptiFineClassTransformer")) {
6059
FPLog.LOG.info("Attaching OptiFine ASM transformer hooks");
6160
transformers.set(i, new WrappedOptiFineClassTransformer(transformer));

src/main/java/com/falsepattern/lib/util/ResourceUtil.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
package com.falsepattern.lib.util;
2424

2525
import com.falsepattern.lib.StableAPI;
26+
import com.falsepattern.lib.internal.FPLog;
2627
import lombok.experimental.UtilityClass;
2728
import lombok.val;
2829

@@ -125,15 +126,14 @@ public static InputStream getResourceFromJar(String resourcePath, Class<?> refer
125126
URL resource = new URL("jar:" + file.substring(0, id) + "!" + resourcePath);
126127
return resource.openStream();
127128
} catch (IOException e) {
128-
System.err.println("Failed to load resource " + resourcePath + " from jar " + file.substring(0, id));
129-
e.printStackTrace();
129+
FPLog.LOG.error("Failed to load resource " + resourcePath + " from jar " + file.substring(0, id), e);
130130
}
131131
}
132132
//Fallback logic
133-
System.out.println("Using fallback resource loading logic for "
134-
+ resourcePath
135-
+ " with reference to "
136-
+ referenceClass.getName());
133+
FPLog.LOG.warn("Using fallback resource loading logic for "
134+
+ resourcePath
135+
+ " with reference to "
136+
+ referenceClass.getName());
137137
return referenceClass.getResourceAsStream(resourcePath);
138138
}
139139

0 commit comments

Comments
 (0)