Start work on #481 (JsonWriteFeature)

Author: cowtowncoder

release-notes/VERSION-2.x

@@ -19,6 +19,7 @@ JSON library.
 #467: Create `JsonReadFeature` to move JSON-specific `JsonParser.Feature`s to
 #480: `SerializableString` value can not directly render to Writer
  (requested by Philippe M)
+#481: Create `JsonWriteFeature` to move JSON-specific `JsonGenerator.Feature`s to
 #484: Implement `UTF8JsonGenerator.writeRawValue(SerializableString)` (and
   `writeRaw(..)`) more efficiently
 

src/main/java/com/fasterxml/jackson/core/JsonGenerator.java

@@ -85,8 +85,10 @@ public enum Feature {
          * occurs when used straight from Javascript.
          *<p>
          * Feature is enabled by default (since it is required by JSON specification).
+         *
+         * @deprecated Since 2.10 use {@link com.fasterxml.jackson.core.json.JsonWriteFeature#QUOTE_FIELD_NAMES} instead
          */
-        // @Deprecated
+        @Deprecated
         QUOTE_FIELD_NAMES(true),
 
         /**

src/main/java/com/fasterxml/jackson/core/json/JsonGeneratorImpl.java

@@ -98,6 +98,7 @@ public abstract class JsonGeneratorImpl extends GeneratorBase
     /**********************************************************
      */
 
+    @SuppressWarnings("deprecation")
     public JsonGeneratorImpl(IOContext ctxt, int features, ObjectCodec codec)
     {
         super(features, codec);
@@ -126,6 +127,7 @@ public Version version() {
     /**********************************************************
      */
 
+    @SuppressWarnings("deprecation")
     @Override
     public JsonGenerator enable(Feature f) {
         super.enable(f);
@@ -135,6 +137,7 @@ public JsonGenerator enable(Feature f) {
         return this;
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public JsonGenerator disable(Feature f) {
         super.disable(f);
@@ -144,6 +147,7 @@ public JsonGenerator disable(Feature f) {
         return this;
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     protected void _checkStdFeatureChanges(int newFeatureFlags, int changedFeatures) {
         super._checkStdFeatureChanges(newFeatureFlags, changedFeatures);

src/main/java/com/fasterxml/jackson/core/json/JsonWriteFeature.java

@@ -23,6 +23,7 @@ public enum JsonWriteFeature
      *<p>
      * Feature is enabled by default (since it is required by JSON specification).
      */
+    @SuppressWarnings("deprecation")
     QUOTE_FIELD_NAMES(true, JsonGenerator.Feature.QUOTE_FIELD_NAMES),
 
     /**

src/test/java/com/fasterxml/jackson/core/json/GeneratorFeaturesTest.java

@@ -54,10 +54,14 @@ public void testFieldNameQuoting() throws IOException
         // by default, quoting should be enabled
         _testFieldNameQuoting(f, true);
         // can disable it
-        f.disable(JsonGenerator.Feature.QUOTE_FIELD_NAMES);
+        f = JsonFactory.builder()
+                .disable(JsonWriteFeature.QUOTE_FIELD_NAMES)
+                .build();
         _testFieldNameQuoting(f, false);
         // and (re)enable:
-        f.enable(JsonGenerator.Feature.QUOTE_FIELD_NAMES);
+        f = JsonFactory.builder()
+                .enable(JsonWriteFeature.QUOTE_FIELD_NAMES)
+                .build();
         _testFieldNameQuoting(f, true);
     }
 
@@ -221,8 +225,9 @@ public void testFieldNameQuotingEnabled() throws IOException
 
         // // Then with alternatively configured factory
 
-        JsonFactory f2 = new JsonFactory();
-        f2.disable(JsonGenerator.Feature.QUOTE_FIELD_NAMES);
+        JsonFactory f2 = JsonFactory.builder()
+                .disable(JsonWriteFeature.QUOTE_FIELD_NAMES)
+                .build();
 
         _testFieldNameQuotingEnabled(f2, true, true, "{\"foo\":1}");
         _testFieldNameQuotingEnabled(f2, false, true, "{\"foo\":1}");
@@ -232,6 +237,7 @@ public void testFieldNameQuotingEnabled() throws IOException
         _testFieldNameQuotingEnabled(f2, false, false, "{foo:1}");
     }
 
+    @SuppressWarnings("deprecation")
     private void _testFieldNameQuotingEnabled(JsonFactory f, boolean useBytes,
             boolean useQuotes, String exp) throws IOException
     {

src/test/java/com/fasterxml/jackson/core/json/JsonFactoryTest.java

@@ -92,14 +92,20 @@ public CustomFactory(JsonFactory f, ObjectCodec codec) {
     /**********************************************************************
      */
 
+    @SuppressWarnings("deprecation")
     public void testGeneratorFeatures() throws Exception
     {
         JsonFactory f = new JsonFactory();
         assertNull(f.getCodec());
 
-        f.configure(JsonGenerator.Feature.QUOTE_FIELD_NAMES, true);
+        f = JsonFactory.builder()
+                .configure(JsonWriteFeature.QUOTE_FIELD_NAMES, true)
+                .build();
+        // 24-Oct-2018, tatu: Until 3.x, we'll only have backwards compatible
         assertTrue(f.isEnabled(JsonGenerator.Feature.QUOTE_FIELD_NAMES));
-        f.configure(JsonGenerator.Feature.QUOTE_FIELD_NAMES, false);
+        f = JsonFactory.builder()
+                .configure(JsonWriteFeature.QUOTE_FIELD_NAMES, false)
+                .build();
         assertFalse(f.isEnabled(JsonGenerator.Feature.QUOTE_FIELD_NAMES));
     }