Minor optimization post #3965 for custom ObjectNodes

cowtowncoder · cowtowncoder · commit 318ab687e856 · 2024-06-02T15:41:34.000-07:00
diff --git a/src/main/java/com/fasterxml/jackson/databind/node/ObjectNode.java b/src/main/java/com/fasterxml/jackson/databind/node/ObjectNode.java
@@ -546,7 +546,9 @@ protected void serializeFilteredContents(final JsonGenerator g, final Serializer
      */
     protected Map<String, JsonNode> _contentsToSerialize(SerializerProvider ctxt) {
         if (ctxt.isEnabled(JsonNodeFeature.WRITE_PROPERTIES_SORTED)) {
-            if (!_children.isEmpty()) {
+            if (!_children.isEmpty()
+                    // 02-Jun-2024, tatu: Avoid unnecessary copy for custom impls
+                    && !(_children instanceof TreeMap<?,?>)) {
                 return new TreeMap<>(_children);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -546,7 +546,9 @@ protected void serializeFilteredContents(final JsonGenerator g, final Serializer`
`546`	`546`	`*/`
`547`	`547`	`protected Map<String, JsonNode> _contentsToSerialize(SerializerProvider ctxt) {`
`548`	`548`	`if (ctxt.isEnabled(JsonNodeFeature.WRITE_PROPERTIES_SORTED)) {`
`549`		`- if (!_children.isEmpty()) {`
	`549`	`+ if (!_children.isEmpty()`
	`550`	`+ // 02-Jun-2024, tatu: Avoid unnecessary copy for custom impls`
	`551`	`+ && !(_children instanceof TreeMap<?,?>)) {`
`550`	`552`	`return new TreeMap<>(_children);`
`551`	`553`	`}`
`552`	`554`	`}`