Minor changes post #3864 to avoid changing API (but trading in "sneaky" throws)

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/JsonNode.java

@@ -607,11 +607,14 @@ public byte[] binaryValue() throws IOException {
      * Returns integer value for this node (as {@link BigInteger}), <b>if and only if</b>
      * this node is numeric ({@link #isNumber} returns true). For other
      * types returns <code>BigInteger.ZERO</code>.
+     *<p>
+     * NOTE: In Jackson 2.x MAY throw {@link com.fasterxml.jackson.core.exc.StreamConstraintsException}
+     *   if the scale of the underlying {@link BigDecimal} is too large to convert (NOTE: thrown
+     *   "sneakily" in Jackson 2.x due to API compatibility restrictions)
      *
      * @return {@link BigInteger} value this node contains, if numeric node; <code>BigInteger.ZERO</code> for non-number nodes.
-     * @throws StreamConstraintsException if the scale of the underlying {@link BigDecimal} is too large
      */
-    public BigInteger bigIntegerValue() throws StreamConstraintsException { return BigInteger.ZERO; }
+    public BigInteger bigIntegerValue() { return BigInteger.ZERO; }
 
     /*
     /**********************************************************

src/main/java/com/fasterxml/jackson/databind/deser/std/NumberDeserializers.java

@@ -941,7 +941,7 @@ public BigInteger deserialize(JsonParser p, DeserializationContext ctxt) throws
                     return (BigInteger) getEmptyValue(ctxt);
                 }
                 final BigDecimal bd = p.getDecimalValue();
-                StreamReadConstraints.defaults().validateBigIntegerScale(bd.scale());
+                p.streamReadConstraints().validateBigIntegerScale(bd.scale());
                 return bd.toBigInteger();
             // 29-Jun-2020, tatu: New! "Scalar from Object" (mostly for XML)
             case JsonTokenId.ID_START_OBJECT:

src/main/java/com/fasterxml/jackson/databind/node/BaseJsonNode.java

@@ -1,12 +1,16 @@
 package com.fasterxml.jackson.databind.node;
 
 import java.io.IOException;
+import java.math.BigDecimal;
+import java.math.BigInteger;
 
 import com.fasterxml.jackson.core.*;
+import com.fasterxml.jackson.core.exc.StreamConstraintsException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.JsonSerializable;
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.jsontype.TypeSerializer;
+import com.fasterxml.jackson.databind.util.ExceptionUtil;
 
 /**
  * Abstract base class common to all standard {@link JsonNode}
@@ -269,4 +273,16 @@ protected JsonPointer _jsonPointerIfValid(String exprOrProperty) {
        return null;
    }
 
+   // @since 2.15
+   protected BigInteger _bigIntFromBigDec(BigDecimal value) {
+       try {
+           StreamReadConstraints.defaults().validateBigIntegerScale(value.scale());
+       } catch (StreamConstraintsException e) {
+           // 06-Apr-2023, tatu: Since `JsonNode` does not generally expose Jackson
+           //    exceptions, we need to either wrap possible `StreamConstraintsException`
+           //    or use "sneaky throw". Let's do latter.
+           ExceptionUtil.throwSneaky(e);
+       }
+       return value.toBigInteger();
+   }
 }

src/main/java/com/fasterxml/jackson/databind/node/DecimalNode.java

@@ -5,7 +5,6 @@
 import java.math.BigInteger;
 
 import com.fasterxml.jackson.core.*;
-import com.fasterxml.jackson.core.exc.StreamConstraintsException;
 import com.fasterxml.jackson.databind.*;
 
 /**
@@ -86,9 +85,8 @@ public boolean canConvertToExactIntegral() {
 
 
     @Override
-    public BigInteger bigIntegerValue() throws StreamConstraintsException {
-        StreamReadConstraints.defaults().validateBigIntegerScale(_value.scale());
-        return _value.toBigInteger();
+    public BigInteger bigIntegerValue() {
+        return _bigIntFromBigDec(_value);
     }
 
     @Override

src/main/java/com/fasterxml/jackson/databind/node/NumericNode.java

@@ -4,7 +4,6 @@
 import java.math.BigInteger;
 
 import com.fasterxml.jackson.core.JsonParser;
-import com.fasterxml.jackson.core.exc.StreamConstraintsException;
 
 /**
  * Intermediate value node used for numeric nodes.
@@ -32,7 +31,7 @@ public final JsonNodeType getNodeType()
     @Override public abstract long longValue();
     @Override public abstract double doubleValue();
     @Override public abstract BigDecimal decimalValue();
-    @Override public abstract BigInteger bigIntegerValue() throws StreamConstraintsException;
+    @Override public abstract BigInteger bigIntegerValue();
 
     @Override public abstract boolean canConvertToInt();
     @Override public abstract boolean canConvertToLong();

src/main/java/com/fasterxml/jackson/databind/util/ExceptionUtil.java

@@ -1,5 +1,7 @@
 package com.fasterxml.jackson.databind.util;
 
+import java.io.IOException;
+
 /**
  * Utility methods for dealing with exceptions/throwables
  *
@@ -56,4 +58,14 @@ private static boolean isFatal(Throwable throwable) {
                 || throwable instanceof VerifyError
         );
     }
+
+    public static <T> T throwSneaky(IOException e) {
+        _sneaky(e);
+        return null; // never gets here, needed for compiler tho
+    }
+
+    @SuppressWarnings("unchecked")
+    private static <E extends Throwable> void _sneaky(Throwable e) throws E {
+        throw (E) e;
+    }
 }

src/test/java/com/fasterxml/jackson/databind/node/ObjectNodeTest.java

@@ -1,6 +1,5 @@
 package com.fasterxml.jackson.databind.node;
 
-import java.io.IOException;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.util.*;
@@ -203,7 +202,7 @@ public void testBasicsPutSet()
         assertEquals("foobar", old.textValue());
     }
 
-    public void testBigNumbers() throws IOException
+    public void testBigNumbers()
     {
         ObjectNode n = new ObjectNode(JsonNodeFactory.instance);
         assertStandardEquals(n);