Skip to content

Incorrect buffering with nested builders, @JsonUnwrapped #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cowtowncoder opened this issue Mar 23, 2018 · 1 comment
Closed

Incorrect buffering with nested builders, @JsonUnwrapped #1979

cowtowncoder opened this issue Mar 23, 2018 · 1 comment
Milestone
2.9.5

Comments

@cowtowncoder
Copy link
Member

(note: follow up to #1978)

Looks like there is something off with buffering for @JsonUnwrapped, with nested builders.
After fixing a related problem looks like what we are left with is the real issue.
@cowtowncoder cowtowncoder mentioned this issue Mar 23, 2018
Closed
cowtowncoder added a commit that referenced this issue Mar 23, 2018
@cowtowncoder
Fix #1979
f8c83ae
@cowtowncoder
Copy link
Member Author

Yes, missing END_OBJECT for buffered objects. Would occur with or without builder; just one code path was missing appropriate closing.
Fixed for 2.9.5 and 3.0.0.

@cowtowncoder cowtowncoder added 2.9 and removed 2.9 labels Mar 23, 2018
@cowtowncoder cowtowncoder added this to the 2.9.5 milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.5
Development

No branches or pull requests
1 participant
@cowtowncoder