Skip to content

Commit 68804a4

Browse files
committed
Further clean up wrt #462
1 parent 5887e81 commit 68804a4

File tree

4 files changed

+14
-28
lines changed

4 files changed

+14
-28
lines changed

src/main/java/com/fasterxml/jackson/dataformat/xml/JacksonXmlAnnotationIntrospector.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
* additional xml-specific annotation that Jackson provides. Note, however, that
1515
* there is no JAXB annotation support here; that is provided with
1616
* separate introspector (see
17-
* {@link com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector}).
17+
* https://github.com/FasterXML/jackson-modules-base/tree/master/jaxb,
18+
* class {@code com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector}).
1819
*/
1920
public class JacksonXmlAnnotationIntrospector
2021
extends JacksonAnnotationIntrospector
@@ -46,6 +47,16 @@ public JacksonXmlAnnotationIntrospector(boolean defaultUseWrapper) {
4647
_cfgDefaultUseWrapper = defaultUseWrapper;
4748
}
4849

50+
/*
51+
/**********************************************************************
52+
/* Extended API XML format module requires
53+
/**********************************************************************
54+
*/
55+
56+
public void setDefaultUseWrapper(boolean b) {
57+
_cfgDefaultUseWrapper = b;
58+
}
59+
4960
/*
5061
/**********************************************************************
5162
/* Overrides of JacksonAnnotationIntrospector impls
@@ -148,11 +159,6 @@ public Boolean isOutputAsCData(MapperConfig<?> config, Annotated ann) {
148159
return null;
149160
}
150161

151-
@Override
152-
public void setDefaultUseWrapper(boolean b) {
153-
_cfgDefaultUseWrapper = b;
154-
}
155-
156162
/*
157163
/**********************************************************************
158164
/* Overrides for name, property detection

src/main/java/com/fasterxml/jackson/dataformat/xml/XmlAnnotationIntrospector.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@
1212
public interface XmlAnnotationIntrospector
1313
extends AnnotationIntrospector.XmlExtensions
1414
{
15-
/**
16-
* @since 2.7
17-
*/
18-
public void setDefaultUseWrapper(boolean b);
19-
2015
/*
2116
/**********************************************************************
2217
/* Replacement of 'AnnotationIntrospector.Pair' to use when combining
@@ -94,15 +89,5 @@ public Boolean isOutputAsCData(MapperConfig<?> config, Annotated ann) {
9489
}
9590
return value;
9691
}
97-
98-
@Override
99-
public void setDefaultUseWrapper(boolean b) {
100-
if (_xmlPrimary instanceof XmlAnnotationIntrospector) {
101-
((XmlAnnotationIntrospector)_xmlPrimary).setDefaultUseWrapper(b);
102-
}
103-
if (_xmlSecondary instanceof XmlAnnotationIntrospector) {
104-
((XmlAnnotationIntrospector)_xmlSecondary).setDefaultUseWrapper(b);
105-
}
106-
}
10792
}
10893
}

src/main/java/com/fasterxml/jackson/dataformat/xml/XmlMapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,8 @@ public XmlMapper setDefaultUseWrapper(boolean state) {
264264
// ser and deser configs should usually have the same introspector, so:
265265
AnnotationIntrospector ai0 = getDeserializationConfig().getAnnotationIntrospector();
266266
for (AnnotationIntrospector ai : ai0.allIntrospectors()) {
267-
if (ai instanceof XmlAnnotationIntrospector) {
268-
((XmlAnnotationIntrospector) ai).setDefaultUseWrapper(state);
267+
if (ai instanceof JacksonXmlAnnotationIntrospector) {
268+
((JacksonXmlAnnotationIntrospector) ai).setDefaultUseWrapper(state);
269269
}
270270
}
271271
return this;

src/main/java/com/fasterxml/jackson/dataformat/xml/jaxb/XmlJaxbAnnotationIntrospector.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,4 @@ public Boolean isOutputAsText(MapperConfig<?> config, Annotated ann) {
5959
public Boolean isOutputAsCData(MapperConfig<?> config, Annotated ann) {
6060
return null;
6161
}
62-
63-
@Override
64-
public void setDefaultUseWrapper(boolean b) {
65-
// nothing to do with JAXB
66-
}
6762
}

0 commit comments

Comments
 (0)