Fix #333

Author: cowtowncoder

release-notes/CREDITS-2.x

@@ -31,3 +31,7 @@ Yury Vasyutinskiy (Falland@github)
 * Contributed #232: Implement `writeRawValue` in `ToXmlGenerator`
  (2.9.0)
 
+Nelson Dionisi (ndionisi@github)
+
+* Reported #333: `OutputDecorator` not called with `XmlMapper`
+ (2.10.0)

release-notes/VERSION-2.x

@@ -4,6 +4,11 @@ Project: jackson-dataformat-xml
 = Releases
 ------------------------------------------------------------------------
 
+2.10.0 (not yet released)
+
+#333: `OutputDecorator` not called with `XmlMapper`
+ (reported by Nelson D)
+
 2.9.8 (15-Dec-2018)
 
 #270: Add support for `writeBinary()` with `InputStream` to `ToXMLGenerator`

src/main/java/com/fasterxml/jackson/dataformat/xml/XmlFactory.java

@@ -481,19 +481,20 @@ public ToXmlGenerator createGenerator(OutputStream out) throws IOException {
     public ToXmlGenerator createGenerator(OutputStream out, JsonEncoding enc) throws IOException
     {
         // false -> we won't manage the stream unless explicitly directed to
-        IOContext ctxt = _createContext(out, false);
+        final IOContext ctxt = _createContext(out, false);
         ctxt.setEncoding(enc);
         return new ToXmlGenerator(ctxt,
                 _generatorFeatures, _xmlGeneratorFeatures,
-                _objectCodec, _createXmlWriter(out));
+                _objectCodec, _createXmlWriter(ctxt, out));
     }
 
     @Override
     public ToXmlGenerator createGenerator(Writer out) throws IOException
     {
-        return new ToXmlGenerator(_createContext(out, false),
+        final IOContext ctxt = _createContext(out, false);
+        return new ToXmlGenerator(ctxt,
                 _generatorFeatures, _xmlGeneratorFeatures,
-                _objectCodec, _createXmlWriter(out));
+                _objectCodec, _createXmlWriter(ctxt, out));
     }
 
     @SuppressWarnings("resource")
@@ -502,10 +503,10 @@ public ToXmlGenerator createGenerator(File f, JsonEncoding enc) throws IOExcepti
     {
         OutputStream out = new FileOutputStream(f);
         // true -> yes, we have to manage the stream since we created it
-        IOContext ctxt = _createContext(out, true);
+        final IOContext ctxt = _createContext(out, true);
         ctxt.setEncoding(enc);
         return new ToXmlGenerator(ctxt, _generatorFeatures, _xmlGeneratorFeatures,
-                _objectCodec, _createXmlWriter(out));
+                _objectCodec, _createXmlWriter(ctxt, out));
     }
 
     /*
@@ -645,22 +646,22 @@ protected JsonGenerator _createGenerator(Writer out, IOContext ctxt) throws IOEx
     /**********************************************************************
      */
 
-    protected XMLStreamWriter _createXmlWriter(OutputStream out) throws IOException
+    protected XMLStreamWriter _createXmlWriter(IOContext ctxt, OutputStream out) throws IOException
     {
         XMLStreamWriter sw;
         try {
-            sw = _xmlOutputFactory.createXMLStreamWriter(out, "UTF-8");
+            sw = _xmlOutputFactory.createXMLStreamWriter(_decorate(ctxt, out), "UTF-8");
         } catch (XMLStreamException e) {
             return StaxUtil.throwAsGenerationException(e, null);
         }
         return _initializeXmlWriter(sw);
     }
 
-    protected XMLStreamWriter _createXmlWriter(Writer w) throws IOException
+    protected XMLStreamWriter _createXmlWriter(IOContext ctxt, Writer w) throws IOException
     {
         XMLStreamWriter sw;
         try {
-            sw = _xmlOutputFactory.createXMLStreamWriter(w);
+            sw = _xmlOutputFactory.createXMLStreamWriter(_decorate(ctxt, w));
         } catch (XMLStreamException e) {
             return StaxUtil.throwAsGenerationException(e, null);
         }
@@ -853,4 +854,31 @@ private final static int skipSpace(InputAccessor acc, byte b) throws IOException
         }
     }
 
+    /*
+    /**********************************************************
+    /* Decorators, output
+    /**********************************************************
+     */
+
+    protected OutputStream _decorate(IOContext ioCtxt, OutputStream out) throws IOException
+    {
+        if (_outputDecorator != null) {
+            OutputStream out2 = _outputDecorator.decorate(ioCtxt, out);
+            if (out2 != null) {
+                return out2;
+            }
+        }
+        return out;
+    }
+
+    protected Writer _decorate(IOContext ioCtxt, Writer out) throws IOException
+    {
+        if (_outputDecorator != null) {
+            Writer out2 = _outputDecorator.decorate(ioCtxt, out);
+            if (out2 != null) {
+                return out2;
+            }
+        }
+        return out;
+    }
 }

src/test/java/com/fasterxml/jackson/dataformat/xml/misc/StreamingDecoratorsTest.java

@@ -1,7 +1,6 @@
 package com.fasterxml.jackson.dataformat.xml.misc;
 
 import java.io.*;
-import java.util.*;
 
 import com.fasterxml.jackson.annotation.JsonRootName;
 import com.fasterxml.jackson.dataformat.xml.*;