Tweaks to #244 fix, update release notes

Author: cowtowncoder

release-notes/CREDITS-2.x

@@ -179,7 +179,7 @@ Suminda Sirinath Salpitikorala Dharmasena (sirinath@github)
  (2.13.0)
 
 Jonas Konrad (yawkat@github)
-#219: Add TOML (https://en.wikipedia.org/wiki/TOML) support
+* Contributed #219: Add TOML (https://en.wikipedia.org/wiki/TOML) support
  (2.13.0)
 
 Krzysztof Debski (kdebski85@github)
@@ -191,7 +191,7 @@ PJ Fanning (pjfanning@github)
 #283: (csv) `CsvSchema.getColumnDesc()` returns unpaired square bracket when columns
   are empty
  (2.13.0)
-#314: (csv) Add fast floating-point parsing, generation support
+* Contributed #314: (csv) Add fast floating-point parsing, generation support
  (2.14.0)
 
 Falk Hanisch (mrpiggi@github)
@@ -208,6 +208,13 @@ Esteban Ginez (eginez@github)
  (2.13.2)
 
 Jim Talbut (Yaytay@github)
-#169: Need a way to escape dots in property keys (add path separator configuration)
+#169: (properties) Need a way to escape dots in property keys (add path separator configuration)
  (2.14.0)
 
+Simon Dean (msmsimondean@github)
+* Requested #244: (yaml) Add `YAMLGenerator.Feature.ALLOW_LONG_KEYS` to allow writing keys
+  longer than 128 characters (default)
+
+Shauni Arima (ShauniArima@github)
+* Contributed #244: (yaml) Add `YAMLGenerator.Feature.ALLOW_LONG_KEYS` to allow writing keys
+  longer than 128 characters (default)

release-notes/VERSION-2.x

@@ -16,8 +16,12 @@ Active Maintainers:
 
 2.14.0 (not yet released)
 
-#169: Need a way to escape dots in property keys (add path separator configuration)
+#169: (properties) Need a way to escape dots in property keys (add path separator configuration)
  (contributed by Jim T)
+#244: (yaml) Add `YAMLGenerator.Feature.ALLOW_LONG_KEYS` to allow writing keys longer than
+  128 characters (default)
+ (requested by Simon D)
+ (contributed by Shauni A)
 #285: (csv) Missing columns from header line (compare to `CsvSchema`) not detected
   when reordering columns (add `CsvParser.Feature.FAIL_ON_MISSING_HEADER_COLUMNS`)
  (reported by Björn M)

yaml/src/main/java/com/fasterxml/jackson/dataformat/yaml/YAMLGenerator.java

@@ -139,14 +139,17 @@ public enum Feature implements FormatFeature // since 2.9
         USE_PLATFORM_LINE_BREAKS(false),
 
         /**
-         * Option passed to SnakeYAML to enable usage of key longer that 128 characters.
-         * If disabled, the max key length is set to 128 characters.
+         * Option passed to SnakeYAML to allows writing key longer that 128 characters
+         * (up to 1024 characters).
+         * If disabled, the max key length is left as 128 characters: longer names
+         * are truncated. If enabled, limit is raised to 1024 characters.
          * <p>
-         * Default value is {@code false}.
+         * Default value is {@code false} for backwards-compatibility (same as behavior
+         * before this feature was added).
          * 
          * @since 2.14
          */
-        USE_LONG_KEYS(false),
+        ALLOW_LONG_KEYS(false),
         ;
 
         protected final boolean _defaultState;
@@ -321,7 +324,7 @@ protected DumperOptions buildDumperOptions(int jsonFeatures, int yamlFeatures,
             opt.setLineBreak(DumperOptions.LineBreak.getPlatformLineBreak());
         }
 
-        if (Feature.USE_LONG_KEYS.enabledIn(_formatFeatures)) {
+        if (Feature.ALLOW_LONG_KEYS.enabledIn(_formatFeatures)) {
             opt.setMaxSimpleKeyLength(1024);
         }
         return opt;

yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/ser/GeneratorFeatureTest.java

@@ -74,7 +74,7 @@ public void testLongKeys() throws Exception
         assertEquals("---\n? " + LONG_KEY + "\n: \"value\"",
         _trim(defaultMapper.writeValueAsString(inputValue)));
 
-        ObjectMapper longKeysMapper = YAMLMapper.builder().enable(YAMLGenerator.Feature.USE_LONG_KEYS).build();
+        ObjectMapper longKeysMapper = YAMLMapper.builder().enable(YAMLGenerator.Feature.ALLOW_LONG_KEYS).build();
         assertEquals("---\n" + LONG_KEY + ": \"value\"",
                 _trim(longKeysMapper.writeValueAsString(inputValue)));
     }