Skip to content

Commit 69ec7d0

Browse files
committed
... but need to move tests for #71 back under failing for 3.x due to diff in yaml engine
1 parent b50ad8b commit 69ec7d0

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

yaml/src/main/java/com/fasterxml/jackson/dataformat/yaml/YAMLParser.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,6 @@ protected JsonToken _decodeScalar(ScalarEvent scalar) throws IOException
441441
final int len = value.length();
442442
if (!typeTagOptional.isPresent() || typeTagOptional.get().equals("!")) { // no, implicit
443443
Tag nodeTag = _yamlResolver.resolve(value, scalar.getImplicit().canOmitTagInPlainScalar());
444-
445444
if (nodeTag == Tag.STR) {
446445
return JsonToken.VALUE_STRING;
447446
}

yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/deser/NumberAltIntRead71Test.java renamed to yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/NumberAltIntRead71Test.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.fasterxml.jackson.dataformat.yaml.deser;
1+
package com.fasterxml.jackson.dataformat.yaml.failing;
22

33
import java.math.BigInteger;
44

@@ -7,6 +7,10 @@
77

88
// [dataformats-text#71]: hex numbers
99
// [dataformats-text#233]: also binary, octal (with/without underscores)
10+
//
11+
// 23-Nov-2020, tatu: Alas, snakeyaml_engine does not really support
12+
// detecting these variants (maybe wrt YAML 1.1 -> 1.2 changes).
13+
// So tests fail. Not sure what to do about this.
1014
public class NumberAltIntRead71Test extends ModuleTestBase
1115
{
1216
static class IntHolder {

0 commit comments

Comments
 (0)