-
-
Notifications
You must be signed in to change notification settings - Fork 178
Add Moditect, source module info, to allow Kotlin module usage with Java Module system #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good Hacktoberfest issue too probably. cc @GedMarc who is the Moditect/module-info wizard. |
I'll see if I can setup a base with the kotlin coordinates |
@GedMarc Excited to see this, let me know if you need any help. I haven't actually anything with modules yet…but maybe I can be useful eyes? |
I think we have a test suite: https://github.com/FasterXML/jackson-jdk11-compat-test which might also help in verification. |
The module info looks like so - kotlin needs base + desktop I'll look at getting it into the module and the test cases
|
Hi, I met this issue, just wondering have you met the same one? #402 |
Since Jackson does not require Java 9 (or higher baseline), module system can not be used to create
module-info.class
.But most Jackson components/modules are using Moditect (https://github.com/moditect/moditect) -- support added in 2.11 -- to produce necessary metadata even when building using Java 8 tools.
It would be good to add necessary build support to Kotlin module too.
This issue:
FasterXML/jackson-databind#2273
can show what is needed; basic addition would be:
src/moditect/module-info.java
with dependency definitions (see Joda module's file, f.ex: https://github.com/FasterXML/jackson-datatype-joda/blob/2.12/src/moditect/module-info.java )pom.xml
(see https://github.com/FasterXML/jackson-datatype-joda/blob/2.12/pom.xml#L106 )with appropriate modifications -- mostly, need to know Kotlin core module's JPMS coordinates.
The text was updated successfully, but these errors were encountered: