Fix #25 for 2.4[.7] for lark

Author: cowtowncoder

release-notes/VERSION

@@ -6,6 +6,10 @@ Project: jackson-module-mrbean
 
 2.5.0 (not yet released)
 
+2.4.67 (not released -- may or may not be released)
+
+#25: Should ignore `static` methods (setter/getter)
+
 2.4.6 (23-Apr-2015)
 2.4.5 (13-Jan-2015)
 2.4.4 (24-Nov-2014)

src/main/java/com/fasterxml/jackson/module/mrbean/BeanBuilder.java

@@ -8,6 +8,7 @@
 import org.objectweb.asm.Type;
 
 import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.LinkedHashMap;
 import java.util.Map;
@@ -59,9 +60,13 @@ public BeanBuilder implement(boolean failOnUnrecognized)
         for (Class<?> impl : implTypes) {
             // and then find all getters, setters, and other non-concrete methods therein:
             for (Method m : impl.getDeclaredMethods()) {
+                // 15-Sep-2015, tatu: As per [module-mrbean#25], make sure to ignore static
+                //    methods.
+                if (Modifier.isStatic(m.getModifiers())) {
+                    continue;
+                }
                 String methodName = m.getName();
                 int argCount = m.getParameterTypes().length;
-    
                 if (argCount == 0) { // getter?
                     if (methodName.startsWith("get") || methodName.startsWith("is") && returnsBoolean(m)) {
                         addGetter(m);

src/test/java/com/fasterxml/jackson/module/mrbean/TestStaticMethods.java

@@ -0,0 +1,82 @@
+package com.fasterxml.jackson.module.mrbean;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+/**
+ * Test(s) to ensure that `static` methods are not considered to be
+ * accessors.
+ * Specifically, test for [module-mrbean#25]
+ */
+public class TestStaticMethods extends BaseTest
+{
+    static class TestPOJO
+    {
+        public AbstractRoot root;
+
+        public void setRoot(AbstractRoot root) {
+            this.root = root;
+        }
+
+        public AbstractRoot getRoot() {
+            return root;
+        }
+    }
+
+    public static class Root extends AbstractRoot {
+        public Root() {}
+    }
+
+    public static abstract class AbstractRoot
+    {
+        static Leaf leaf;
+
+        private int x;
+
+        public AbstractRoot() {}
+
+        // bogus: being static, ought to be skipped
+        public static void setLeaf(Leaf leaf) {
+            AbstractRoot.leaf = leaf;
+        }
+
+        public int getX() {
+            return x;
+        }
+
+        public void setX(int x) {
+            this.x = x;
+        }
+    }
+
+    //Bad jackson class, to generate the IllegalArgumentException
+    //This class should be ignored by Jackson
+    static class Leaf
+    {
+        public String test;
+
+        public void setTest(String test) {
+            this.test = test;
+        }
+
+        public void setTest(StringBuilder test) {
+            this.test = test.toString();
+        }
+    }
+
+    public void testAbstract25() throws Exception
+    {
+        TestPOJO v = new TestPOJO();
+
+        Root root = new Root();
+        root.setX(2);
+
+        v.setRoot(root);
+
+        ObjectMapper mapper = new ObjectMapper();
+        mapper.registerModule(new MrBeanModule());
+        String jsonValue = mapper.writeValueAsString(v);
+
+        TestPOJO result = mapper.readValue(jsonValue, TestPOJO.class);
+        assertNotNull(result);
+    }
+}