Skip to content

Commit 758b700

Browse files
authored
Merge pull request #217 from JooHyukKim/Follow-up-with-TODOs-in-#216
Follow up wrt #191 by using `NativeImageUtil.isRunningInNativeImage()` in `databind`
2 parents d750d6e + b047518 commit 758b700

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

afterburner/src/main/java/com/fasterxml/jackson/module/afterburner/AfterburnerModule.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@
22

33
import com.fasterxml.jackson.core.Version;
44
import com.fasterxml.jackson.databind.Module;
5+
import com.fasterxml.jackson.databind.util.NativeImageUtil;
56
import com.fasterxml.jackson.module.afterburner.ser.SerializerModifier;
67
import com.fasterxml.jackson.module.afterburner.deser.DeserializerModifier;
78

89
public class AfterburnerModule extends Module
910
implements java.io.Serializable // is this necessary?
1011
{
11-
// TODO: replace with jackson-databind/NativeImageUtil.RUNNING_IN_SVM
12-
private static final boolean RUNNING_IN_SVM = System.getProperty("org.graalvm.nativeimage.imagecode") != null;
1312
private static final long serialVersionUID = 1L;
1413

1514
/*
@@ -51,7 +50,8 @@ public AfterburnerModule() { }
5150
@Override
5251
public void setupModule(SetupContext context)
5352
{
54-
if (RUNNING_IN_SVM)
53+
// [modules-base#191] Since 2.16, Native image detection
54+
if (NativeImageUtil.isInNativeImage())
5555
{
5656
return;
5757
}

blackbird/src/main/java/com/fasterxml/jackson/module/blackbird/BlackbirdModule.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.fasterxml.jackson.module.blackbird;
22

3+
import com.fasterxml.jackson.databind.util.NativeImageUtil;
34
import java.lang.invoke.MethodHandles;
45
import java.lang.invoke.MethodHandles.Lookup;
56
import java.util.function.Function;
@@ -12,8 +13,6 @@
1213

1314
public class BlackbirdModule extends Module
1415
{
15-
// TODO: replace with jackson-databind/NativeImageUtil.RUNNING_IN_SVM
16-
private static final boolean RUNNING_IN_SVM = System.getProperty("org.graalvm.nativeimage.imagecode") != null;
1716
private Function<Class<?>, Lookup> _lookups;
1817

1918
public BlackbirdModule() {
@@ -37,7 +36,8 @@ public BlackbirdModule(Supplier<MethodHandles.Lookup> lookup) {
3736
@Override
3837
public void setupModule(SetupContext context)
3938
{
40-
if (RUNNING_IN_SVM)
39+
// [modules-base#191] Since 2.16, Native image detection
40+
if (NativeImageUtil.isInNativeImage())
4141
{
4242
return;
4343
}

0 commit comments

Comments
 (0)