Fix #42

Author: cowtowncoder

mrbean/src/main/java/com/fasterxml/jackson/module/mrbean/AbstractTypeMaterializer.java

@@ -72,10 +72,6 @@ protected static int collectDefaults() {
 
     /**
      * Default package to use for generated classes.
-     *<p>
-     * Note that before 2.6, defaulted to
-     * "org.codehaus.jackson.generated.", changed as
-     * per [mrbean#21]
      */
     public final static String DEFAULT_PACKAGE_FOR_GENERATED = "com.fasterxml.jackson.module.mrbean.generated.";
 

mrbean/src/main/java/com/fasterxml/jackson/module/mrbean/BeanBuilder.java

@@ -83,13 +83,24 @@ public BeanBuilder implement(boolean failOnUnrecognized)
                 String methodName = m.getName();
                 int argCount = m.getParameterTypes().length;
                 if (argCount == 0) { // getter?
-                    if (methodName.startsWith("get") || methodName.startsWith("is") && returnsBoolean(m)) {
-                        addGetter(ctxt, m);
+                    if (methodName.startsWith("get")) {
+                        if (methodName.length() > 3) { // ignore plain "get()"
+                            addGetter(ctxt, m);
+                            continue;
+                        }
+                    } else if (methodName.startsWith("is")) {
+                        if (methodName.length() > 2) { // ignore plain "is()"
+                            if (returnsBoolean(m)) {
+                                addGetter(ctxt, m);
+                                continue;
+                            }
+                        }
+                    }
+                } else if ((argCount == 1) && methodName.startsWith("set")) { // ignore "set()"
+                    if (methodName.length() > 3) {
+                        addSetter(ctxt, m);
                         continue;
                     }
-                } else if (argCount == 1 && methodName.startsWith("set")) {
-                    addSetter(ctxt, m);
-                    continue;
                 }
                 // Otherwise, if concrete, or already handled, skip:
                 if (BeanUtil.isConcrete(m) || _unsupportedMethods.containsKey(methodName)) {

mrbean/src/test/java/com/fasterxml/jackson/module/mrbean/TestSimpleMaterializedInterfaces.java

@@ -36,7 +36,7 @@ public interface PartialBean {
     public interface BeanHolder {
         public Bean getBean();
     }
-    
+
     // then invalid one; conflicting setter/getter types
     public interface InvalidBean {
         public int getX();
@@ -184,11 +184,11 @@ public void testSubInterface() throws Exception
      */
     public void testPartialBean() throws Exception
     {
-        ObjectMapper mapper = new ObjectMapper();
         AbstractTypeMaterializer mat = new AbstractTypeMaterializer();
         // ensure that we will only get deferred error methods
         mat.disable(AbstractTypeMaterializer.Feature.FAIL_ON_UNMATERIALIZED_METHOD);
-        mapper.registerModule(new MrBeanModule(mat));
+        ObjectMapper mapper = new ObjectMapper()
+                .registerModule(new MrBeanModule(mat));
         PartialBean bean = mapper.readValue("{\"ok\":true}", PartialBean.class);
         assertNotNull(bean);
         assertTrue(bean.isOk());

mrbean/src/test/java/com/fasterxml/jackson/module/mrbean/TestSimpleTypes.java

@@ -3,6 +3,7 @@
 import java.util.*;
 
 import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 public class TestSimpleTypes extends BaseTest
@@ -20,6 +21,15 @@ public IntegerBean() { }
         public void setId(final Integer pId) { id = pId; }
     }    
 
+    // for [modules-base#42]: ignore `get()` and `set()`
+    public static interface JustGetAndSet {
+        public int get();
+
+        public void set(int x);
+
+        public int foobar();
+    }
+
     /*
     /**********************************************************
     /* Unit tests
@@ -39,4 +49,23 @@ public void testIssue19() throws Exception
         final Map<String, Object> data = MAPPER.readValue(json, typeMap);
         assertEquals(Integer.valueOf(60), data.get("id"));        
     }
+
+    // for [modules-base#42]: ignore `get()` and `set()`
+    public void testPlainGetAndSet() throws Exception
+    {
+        JustGetAndSet value = MAPPER.readValue("{}", JustGetAndSet.class);
+        // fine to have unimplemented methods, unless...
+        assertNotNull(value);
+
+        AbstractTypeMaterializer mat = new AbstractTypeMaterializer();
+        mat.enable(AbstractTypeMaterializer.Feature.FAIL_ON_UNMATERIALIZED_METHOD);
+        ObjectMapper mapper = new ObjectMapper()
+                .registerModule(new MrBeanModule(mat));
+        try {
+            mapper.readValue("{}", JustGetAndSet.class);
+            fail("Should not pass");
+        } catch (JsonMappingException e) {
+            verifyException(e, "Unrecognized abstract method");
+        }
+    }
 }

release-notes/VERSION

@@ -10,6 +10,11 @@ Modules:
 
 2.9.0 (not yet released)
 
+2.8.11.1 (not yet released)
+
+#42: NPE from MrBean when `get()` or `set()` is though as property
+ (reported by Tuomas K)
+
 2.8.11 (24-Dec-2017)
 
 #30: (afterburner) `IncompatibleClassChangeError` deserializing interface