Skip to content

Commit 858fb7e

Browse files
committed
fix: server event compile failed
1 parent ceea0af commit 858fb7e

File tree

6 files changed

+17
-21
lines changed

6 files changed

+17
-21
lines changed

.rusty-hook.toml

Lines changed: 0 additions & 5 deletions
This file was deleted.

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22
edition = "2021"
33
name = "feature-probe-server-sdk"
4-
version = "1.2.1"
4+
version = "1.2.2"
55
license = "Apache-2.0"
66
authors = ["maintain@featureprobe.com"]
77
description = "FeatureProbe Server Side SDK for Rust"
@@ -45,12 +45,12 @@ url = "2"
4545

4646
feature-probe-event-std = { optional = true, version = "1.1.2", package = "feature-probe-event" }
4747
feature-probe-event-tokio = { optional = true, version = "1.1.2", features = [
48-
"use_tokio",
48+
"use_tokio",
4949
], default-features = false, package = "feature-probe-event" }
5050

5151
reqwest = { optional = true, version = "0.11", default-features = false, features = [
52-
"rustls-tls",
53-
"json",
52+
"rustls-tls",
53+
"json",
5454
] }
5555
tokio = { optional = true, version = "1", features = ["full"] }
5656
ureq = { optional = true, version = "2.4" }

src/evalutate.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use std::string::String;
1111
use std::{collections::HashMap, str::FromStr};
1212
use tracing::{info, warn};
1313

14-
#[derive(Serialize, Deserialize, Debug, PartialEq)]
14+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq)]
1515
#[serde(rename_all = "camelCase")]
1616
pub enum Serve {
1717
Select(usize),
@@ -52,10 +52,10 @@ impl Serve {
5252
}
5353
}
5454

55-
#[derive(Serialize, Deserialize, Debug, PartialEq)]
55+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq)]
5656
struct BucketRange((u32, u32));
5757

58-
#[derive(Serialize, Deserialize, Debug, PartialEq)]
58+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq)]
5959
#[serde(rename_all = "camelCase")]
6060
pub struct Distribution {
6161
distribution: Vec<Vec<BucketRange>>,
@@ -130,7 +130,7 @@ pub struct EvalParams<'a> {
130130
segment_repo: &'a HashMap<String, Segment>,
131131
}
132132

133-
#[derive(Serialize, Deserialize, Debug, PartialEq, Default)]
133+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Default)]
134134
#[serde(rename_all = "camelCase")]
135135
pub struct EvalDetail<T> {
136136
pub value: Option<T>,
@@ -140,7 +140,7 @@ pub struct EvalDetail<T> {
140140
pub reason: String,
141141
}
142142

143-
#[derive(Serialize, Deserialize, Debug, PartialEq)]
143+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq)]
144144
#[serde(rename_all = "camelCase")]
145145
pub struct Toggle {
146146
key: String,
@@ -296,7 +296,7 @@ struct DefaultRule {
296296
pub serve: Serve,
297297
}
298298

299-
#[derive(Serialize, Deserialize, Debug, PartialEq)]
299+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq)]
300300
struct Rule {
301301
serve: Serve,
302302
conditions: Vec<Condition>,
@@ -317,7 +317,7 @@ impl Rule {
317317
}
318318
}
319319

320-
#[derive(Serialize, Deserialize, Debug, PartialEq, Clone)]
320+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Clone)]
321321
#[serde(rename_all = "camelCase")]
322322
enum ConditionType {
323323
String,
@@ -329,7 +329,7 @@ enum ConditionType {
329329
Unknown,
330330
}
331331

332-
#[derive(Serialize, Deserialize, Debug, PartialEq, Clone)]
332+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Clone)]
333333
struct Condition {
334334
r#type: ConditionType,
335335
#[serde(default)]
@@ -425,14 +425,14 @@ impl Condition {
425425
},
426426
None => unix_timestamp() / 1000,
427427
};
428-
return match predicate {
428+
match predicate {
429429
"after" => self.do_match::<u128>(&c, |c, o| c.ge(o)),
430430
"before" => self.do_match::<u128>(&c, |c, o| c.lt(o)),
431431
_ => {
432432
info!("unknown predicate {}", predicate);
433433
false
434434
}
435-
};
435+
}
436436
}
437437

438438
fn do_match<T: FromStr>(&self, t: &T, f: fn(&T, &T) -> bool) -> bool {

src/feature_probe.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ impl FeatureProbe {
122122

123123
pub fn close(&self) {
124124
info!("closing featureprobe client");
125+
#[cfg(any(feature = "event", feature = "event_tokio"))]
125126
if let Some(recorder) = &self.event_recorder {
126127
recorder.flush();
127128
}

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ lazy_static! {
2020

2121
const VERSION: &str = env!("CARGO_PKG_VERSION");
2222

23-
#[derive(Serialize, Deserialize, Debug, PartialEq, Default)]
23+
#[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Default)]
2424
#[serde(rename_all = "camelCase")]
2525
pub struct FPDetail<T: Default + Debug> {
2626
pub value: T,

0 commit comments

Comments
 (0)