Skip to content

Commit ff57463

Browse files
committed
hacky - check for null to satisfy tests
1 parent d8fe527 commit ff57463

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

SharedProject/Core/MsTestPlatform/CodeCoverage/RunSettingsTemplate.cs

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,21 @@ private XElement GetMsDataCollectorCodeCoverageElement(XDocument templateDocumen
220220
return msDataCollector.GetStrictDescendant("Configuration/CodeCoverage");
221221
}
222222

223+
// hacky. due to tests
224+
private string SafeFilePathEscape(string path)
225+
{
226+
if (path == null)
227+
{
228+
return null;
229+
}
230+
return XmlFileEscaper.Escape(path);
231+
}
232+
223233
public string Replace(string templatedXml, IRunSettingsTemplateReplacements replacements)
224234
{
225235
return templatedXml
226-
.Replace(replacementLookups.ResultsDirectory, XmlFileEscaper.Escape(replacements.ResultsDirectory))
227-
.Replace(replacementLookups.TestAdapter, XmlFileEscaper.Escape(replacements.TestAdapter))
236+
.Replace(replacementLookups.ResultsDirectory, SafeFilePathEscape(replacements.ResultsDirectory))
237+
.Replace(replacementLookups.TestAdapter, SafeFilePathEscape(replacements.TestAdapter))
228238
.Replace(replacementLookups.Enabled, replacements.Enabled)
229239
.Replace(replacementLookups.ModulePathsExclude, replacements.ModulePathsExclude)
230240
.Replace(replacementLookups.ModulePathsInclude, replacements.ModulePathsInclude)

0 commit comments

Comments
 (0)