Skip to content

Commit 90334fc

Browse files
authored
fix: 🐛 log stack only saved for logged_messages.all (#278)
Previously, the same log entry was only saved to the previous entry in `ModLoaderStore.logged_messages.all[logMD5]`. This change adds a check for an `existing_entry` and adds to the entry stacks in `ModLoaderStore.logged_messages.by_mod` and `ModLoaderStore.logged_messages.by_type`.
1 parent 8f030b2 commit 90334fc

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

addons/mod_loader/api/log.gd

+5-3
Original file line numberDiff line numberDiff line change
@@ -249,13 +249,15 @@ static func _get_verbosity() -> int:
249249

250250

251251
static func _store_log(log_entry: ModLoaderLogEntry) -> void:
252+
var existing_entry: ModLoaderLogEntry
253+
252254
# Store in all
253255
# If it's a new entry
254256
if not ModLoaderStore.logged_messages.all.has(log_entry.get_md5()):
255257
ModLoaderStore.logged_messages.all[log_entry.get_md5()] = log_entry
256258
# If it's a existing entry
257259
else:
258-
var existing_entry: ModLoaderLogEntry = ModLoaderStore.logged_messages.all[log_entry.get_md5()]
260+
existing_entry = ModLoaderStore.logged_messages.all[log_entry.get_md5()]
259261
existing_entry.time = log_entry.time
260262
existing_entry.stack.push_back(log_entry)
261263

@@ -264,10 +266,10 @@ static func _store_log(log_entry: ModLoaderLogEntry) -> void:
264266
if not ModLoaderStore.logged_messages.by_mod.has(log_entry.mod_name):
265267
ModLoaderStore.logged_messages.by_mod[log_entry.mod_name] = {}
266268

267-
ModLoaderStore.logged_messages.by_mod[log_entry.mod_name][log_entry.get_md5()] = log_entry
269+
ModLoaderStore.logged_messages.by_mod[log_entry.mod_name][log_entry.get_md5()] = log_entry if not existing_entry else existing_entry
268270

269271
# Store in by_type
270-
ModLoaderStore.logged_messages.by_type[log_entry.type.to_lower()][log_entry.get_md5()] = log_entry
272+
ModLoaderStore.logged_messages.by_type[log_entry.type.to_lower()][log_entry.get_md5()] = log_entry if not existing_entry else existing_entry
271273

272274

273275
static func _is_logged_before(entry: ModLoaderLogEntry) -> bool:

0 commit comments

Comments
 (0)