Skip to content

Commit 7847224

Browse files
feat(ref: #129): enhancement
feat(ref: #129): enhancement
2 parents 55daf61 + f5531da commit 7847224

19 files changed

+4130
-107
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+13-13
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,24 @@
22

33
Please check if your PR fulfills the following requirements:
44

5-
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
6-
- [ ] Tests for the changes have been added (for bug fixes / features)
7-
- [ ] Docs have been added / updated (for bug fixes / features)
5+
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-loader-indicator/blob/develop/CONTRIBUTING.md#commit
6+
- [ ] Tests for the changes have been added (for bug fixes / features)
7+
- [ ] Docs have been added / updated (for bug fixes / features)
88

99
## PR Type
1010

1111
What kind of change does this PR introduce?
1212

1313
<!-- Please check the one that applies to this PR using "x". -->
1414

15-
- [ ] Bugfix
16-
- [ ] Feature
17-
- [ ] Code style update (formatting, local variables)
18-
- [ ] Refactoring (no functional changes, no api changes)
19-
- [ ] Build related changes
20-
- [ ] CI related changes
21-
- [ ] Documentation content changes
22-
- [ ] Other... Please describe:
15+
- [ ] Bugfix
16+
- [ ] Feature
17+
- [ ] Code style update (formatting, local variables)
18+
- [ ] Refactoring (no functional changes, no api changes)
19+
- [ ] Build related changes
20+
- [ ] CI related changes
21+
- [ ] Documentation content changes
22+
- [ ] Other... Please describe:
2323

2424
## What is the current behavior?
2525

@@ -31,8 +31,8 @@ Issue Number: N/A
3131

3232
## Does this PR introduce a breaking change?
3333

34-
- [ ] Yes
35-
- [ ] No
34+
- [ ] Yes
35+
- [ ] No
3636

3737
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
3838

.postcssrc.json

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"plugins": {
3+
"@tailwindcss/postcss": {}
4+
}
5+
}

.stylelintrc.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"scss/at-rule-no-unknown": [
1717
true,
1818
{
19-
"ignoreAtRules": ["tailwind"]
19+
"ignoreAtRules": ["tailwind", "config"]
2020
}
2121
]
2222
}

CHANGELOG.md

+16-10
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,59 @@
1+
# 19.0.1(2025-04-30)
2+
3+
### Feature
4+
5+
- update dependencies
6+
17
# 19.0.0(2024-11-21)
28

39
### Feature
410

5-
- update ng 19.x
11+
- update ng 19.x
612

713
# 18.0.4(2024-10-25)
814

915
### Feature
1016

11-
- add tailwind
12-
- change interface to type, remove prefix "I"
13-
- update dependencies
14-
- add ESLint strict rules
17+
- add tailwind
18+
- change interface to type, remove prefix "I"
19+
- update dependencies
20+
- add ESLint strict rules
1521

1622
# 17.3.2(2024-03-29)
1723

1824
### Feature
1925

20-
- change decorators to signals
26+
- change decorators to signals
2127

2228
<a name="17.0.0"></a>
2329

2430
# 17.0.0(2023-11-28)
2531

2632
### Feature
2733

28-
- update ng 17.x
34+
- update ng 17.x
2935

3036
<a name="17.0.0"></a>
3137

3238
# 16.0.1(2023-10-03)
3339

3440
### Feature
3541

36-
- update dependencies
42+
- update dependencies
3743

3844
# 16.0.0(2023-07-07)
3945

4046
### Feature
4147

42-
- update ng 16.x
48+
- update ng 16.x
4349

4450
<a name="16.0.0"></a>
4551

4652
# 15.0.0(2022-26-12)
4753

4854
### Feature
4955

50-
- update to ng15
56+
- update to ng15
5157

5258
<a name="15.0.0"></a>
5359

CONTRIBUTING.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@ Please format code and markup in your issue using [github markdown](https://help
88

99
## Contributing to Source Code (Pull Requests)
1010

11-
- If your PR changes any behavior or fixes an issue, it should have an associated test.
12-
- New features should be general and as simple as possible.
13-
- Breaking changes should be avoided if possible.
14-
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
11+
- If your PR changes any behavior or fixes an issue, it should have an associated test.
12+
- New features should be general and as simple as possible.
13+
- Breaking changes should be avoided if possible.
14+
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
1515

1616
## Protractor specific rules
1717

18-
- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
19-
- Document public methods with jsdoc.
20-
- Be consistent with the code around you!
18+
- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
19+
- Document public methods with jsdoc.
20+
- Be consistent with the code around you!
2121

2222
## Commit Messages
2323

README.md

+8
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,18 @@ You can also try our NGX COPYPASTE [check](https://www.npmjs.com/package/ngx-cop
2323

2424
## Installing
2525

26+
## npm
27+
2628
```bash
2729
$ npm install --save ngx-loader-indicator
2830
```
2931

32+
## bun
33+
34+
```bash
35+
$ bun install --save ngx-loader-indicator
36+
```
37+
3038
## Quickstart if ngx-loader-indicator version >= 15.0.0
3139

3240
Pay attention this version works for angular >= 14.0.0

bun.lock

+4,008
Large diffs are not rendered by default.

bun.lockb

-769 KB
Binary file not shown.

eslint.config.js

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ module.exports = tseslint.config(
7878
'@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
7979
'@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
8080
'@typescript-eslint/no-non-null-assertion': 'error',
81+
'@typescript-eslint/no-redundant-type-constituents': 'off',
8182
'@typescript-eslint/no-this-alias': 'error',
8283
'@typescript-eslint/no-unnecessary-type-constraint': 'error',
8384
'@typescript-eslint/no-unsafe-declaration-merging': 'error',

package.json

+49-51
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-loader-indicator",
3-
"version": "19.0.0",
3+
"version": "19.0.1",
44
"description": "The best directive without wrapping your element to additional component",
55
"license": "MIT",
66
"keywords": [
@@ -36,67 +36,65 @@
3636
"url": "https://github.com/JsDaddy/ngx-loader-indicator.git"
3737
},
3838
"dependencies": {
39-
"@angular/animations": "19.0.0",
40-
"@angular/common": "19.0.0",
41-
"@angular/compiler": "19.0.0",
42-
"@angular/core": "19.0.0",
43-
"@angular/forms": "19.0.0",
44-
"@angular/platform-browser": "19.0.0",
45-
"@angular/platform-browser-dynamic": "19.0.0",
46-
"@angular/router": "^19.0.0",
47-
"core-js": "3.39.0",
48-
"highlight.js": "^11.10.0",
49-
"ngx-highlightjs": "^12.0.0",
50-
"ngxtension": "4.1.0",
51-
"rxjs": "7.8.1"
39+
"@angular/animations": "19.2.8",
40+
"@angular/common": "19.2.8",
41+
"@angular/compiler": "19.2.8",
42+
"@angular/core": "19.2.8",
43+
"@angular/forms": "19.2.8",
44+
"@angular/platform-browser": "19.2.8",
45+
"@angular/platform-browser-dynamic": "19.2.8",
46+
"@angular/router": "^19.2.8",
47+
"@tailwindcss/postcss": "^4.1.4",
48+
"core-js": "3.42.0",
49+
"highlight.js": "^11.11.1",
50+
"ngx-highlightjs": "^14.0.0",
51+
"ngxtension": "5.0.0",
52+
"rxjs": "7.8.2"
5253
},
5354
"devDependencies": {
54-
"@angular-devkit/build-angular": "19.0.0",
55-
"@angular-eslint/builder": "18.4.1",
56-
"@angular-eslint/eslint-plugin": "18.4.1",
57-
"@angular-eslint/eslint-plugin-template": "18.4.1",
58-
"@angular-eslint/schematics": "18.4.1",
59-
"@angular-eslint/template-parser": "18.4.1",
60-
"@angular/cli": "19.0.0",
61-
"@angular/compiler-cli": "19.0.0",
62-
"@angular/language-service": "19.0.0",
63-
"@commitlint/cli": "19.6.0",
64-
"@commitlint/config-conventional": "19.6.0",
65-
"@types/jasmine": "5.1.4",
55+
"@angular-devkit/build-angular": "19.2.9",
56+
"@angular-eslint/builder": "19.3.0",
57+
"@angular-eslint/eslint-plugin": "19.3.0",
58+
"@angular-eslint/eslint-plugin-template": "19.3.0",
59+
"@angular-eslint/schematics": "19.3.0",
60+
"@angular-eslint/template-parser": "19.3.0",
61+
"@angular/cli": "19.2.9",
62+
"@angular/compiler-cli": "19.2.8",
63+
"@angular/language-service": "19.2.8",
64+
"@commitlint/cli": "19.8.0",
65+
"@commitlint/config-conventional": "19.8.0",
66+
"@types/jasmine": "5.1.7",
6667
"@types/jasminewd2": "2.0.13",
67-
"@types/node": "22.9.1",
68-
"@typescript-eslint/eslint-plugin": "8.15.0",
69-
"@web/test-runner": "^0.19.0",
70-
"angular-eslint": "^18.4.1",
71-
"eslint": "9.15.0",
72-
"eslint-config-prettier": "9.1.0",
68+
"@types/node": "22.15.3",
69+
"@typescript-eslint/eslint-plugin": "8.31.1",
70+
"@web/test-runner": "^0.20.1",
71+
"angular-eslint": "^19.3.0",
72+
"eslint": "9.25.1",
73+
"eslint-config-prettier": "10.1.2",
7374
"eslint-plugin-import": "2.31.0",
7475
"eslint-plugin-json": "4.0.1",
75-
"eslint-plugin-prettier": "5.2.1",
76-
"jasmine-core": "5.4.0",
76+
"eslint-plugin-prettier": "5.2.6",
77+
"jasmine-core": "5.7.0",
7778
"jasmine-spec-reporter": "7.0.0",
78-
"lint-staged": "15.2.10",
79-
"ng-packagr": "19.0.0",
80-
"npm-check-updates": "^17.1.11",
81-
"prettier": "3.3.3",
82-
"puppeteer": "23.9.0",
83-
"semantic-release": "24.2.0",
79+
"lint-staged": "15.5.1",
80+
"ng-packagr": "19.2.2",
81+
"npm-check-updates": "^18.0.1",
82+
"prettier": "3.5.3",
83+
"puppeteer": "24.7.2",
84+
"semantic-release": "24.2.3",
8485
"semantic-release-export-data": "1.1.0",
85-
"snyk": "^1.1294.1",
86-
"stylelint": "16.10.0",
86+
"snyk": "^1.1296.2",
87+
"stylelint": "16.19.1",
8788
"stylelint-config-prettier": "9.0.5",
8889
"stylelint-config-recommended-scss": "14.1.0",
89-
"stylelint-prettier": "5.0.2",
90+
"stylelint-prettier": "5.0.3",
9091
"ts-node": "10.9.2",
9192
"type-coverage": "^2.29.7",
92-
"typescript": "5.6.3",
93-
"typescript-eslint": "^8.15.0",
94-
"tailwindcss": "^3.4.15",
95-
"bun-types": "^1.1.36",
96-
"postcss": "8.4.49",
97-
"postcss-nesting": "13.0.1",
98-
"cssnano": "7.0.6",
99-
"postcss-scss": "4.0.9"
93+
"typescript": "5.8.3",
94+
"typescript-eslint": "^8.31.1",
95+
"tailwindcss": "^4.1.4",
96+
"bun-types": "^1.2.11",
97+
"postcss": "^8.5.3"
10098
},
10199
"typeCoverage": {
102100
"atLeast": 98,

postcss.config.js

-8
This file was deleted.

projects/ngx-loader-indicator-lib/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-loader-indicator",
3-
"version": "19.0.0",
3+
"version": "19.0.1",
44
"description": "The best directive without wrapping your element to additional component",
55
"license": "MIT",
66
"keywords": [

src/app/app.component.scss

-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +0,0 @@
1-
:host {
2-
@apply block h-full;
3-
}

src/app/app.component.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component } from '@angular/core';
1+
import { Component, HostBinding } from '@angular/core';
22
import { HeaderComponent } from '@open-source/header/header.component';
33
import { AccordionComponent } from '@open-source/accordion/accordion.component';
44
import { SubHeaderComponent } from '@open-source//sub-header/sub-header.component';
@@ -35,4 +35,7 @@ export class AppComponent {
3535
public readonly subtitle =
3636
'Awesome loader for angular applications. No wrappers only you elements';
3737
public readonly chips = ['Website', 'Angular', 'Typescript', 'Carousel', 'Spinner'];
38+
39+
@HostBinding('class')
40+
public readonly hostClassname = 'block h-full';
3841
}

src/app/cards/cards.component.scss

-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +0,0 @@
1-
:host {
2-
@apply flex flex-col gap-4 p-4 bg-full-white box-border border-t border-t-black/10 py-5 pl-[22px] pr-4;
3-
}

src/app/cards/cards.component.ts

+13-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
1-
import { Component, effect, ElementRef, inject, input, viewChildren } from '@angular/core';
1+
import {
2+
Component,
3+
effect,
4+
ElementRef,
5+
HostBinding,
6+
inject,
7+
input,
8+
viewChildren,
9+
} from '@angular/core';
210
import { NgOptimizedImage } from '@angular/common';
311
import { HighlightModule } from 'ngx-highlightjs';
412
import { CardItem } from './cards.type';
@@ -29,6 +37,10 @@ export class CardsComponent {
2937
private readonly scrollService = inject(ScrollService);
3038
public readonly activeCardId = toSignal(this.scrollService.activeCard$);
3139

40+
@HostBinding('class')
41+
public readonly hostClassname =
42+
'flex flex-col gap-4 p-4 bg-full-white box-border border-t border-t-black/10 py-5 pl-[22px] pr-4';
43+
3244
public constructor() {
3345
effect(() => {
3446
this.scrollService.onScroll(this.cards());

src/styles.scss

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
@use './libraries/styles/scroll-bar';
2-
3-
@tailwind base;
4-
@tailwind components;
5-
@tailwind utilities;
2+
@use 'tailwindcss';
3+
@config '../tailwind.config';

tailwind.config.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import { type Config } from 'tailwindcss';
2-
3-
const tailwindConfig: Config = {
1+
const tailwindConfig = {
42
content: ['./src/**/*.{html,scss,ts}'],
53
theme: {
64
extend: {

0 commit comments

Comments
 (0)