Skip to content

Type instability in cg #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mohamed82008 opened this issue Mar 25, 2018 · 2 comments
Closed

Type instability in cg #194

mohamed82008 opened this issue Mar 25, 2018 · 2 comments

Comments

@mohamed82008
Copy link
Member

https://github.com/JuliaMath/IterativeSolvers.jl/blob/756edef2b6a58a65b41f87127fbec1f8c62150c7/src/cg.jl#L203
The above line creates a type instability. Can be fixed by making log::Type{Val{logging}} and making logging a type parameter.
@andreasnoack
Copy link
Member

Remember that we've constant propagation on 0.7 so I wouldn't use any Val for this.

@haampie
Copy link
Member

haampie commented Mar 25, 2018 •
edited
Loading

Duplicate of #192. See also #185.

@haampie haampie marked this as a duplicate of #192 Mar 25, 2018
@haampie haampie closed this as completed Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@haampie @andreasnoack @mohamed82008