Merge pull request #2 from yuiyuiui/WaitForReview

check tab

Author: yuiyuiui

Project.toml

@@ -8,7 +8,7 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 PackageExtensionCompat = "65ce6f38-6b18-4e1d-a461-8949797d7930"
 Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
-TestExtras = "5ed8adda-3752-4e41-b88a-e8b09835ee3a"
+SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 VectorInterface = "409d34a3-91d5-4945-b6ec-7529ddf182d8"
 
 [weakdeps]
@@ -27,6 +27,7 @@ Logging = "1"
 PackageExtensionCompat = "1"
 Printf = "1"
 Random = "1"
+SparseArrays = "1.11.0"
 Test = "1"
 TestExtras = "0.2,0.3"
 VectorInterface = "0.5"

src/KrylovKit.jl

@@ -37,7 +37,7 @@ export initialize, initialize!, expand!, shrink!
 export ClassicalGramSchmidt, ClassicalGramSchmidt2, ClassicalGramSchmidtIR
 export ModifiedGramSchmidt, ModifiedGramSchmidt2, ModifiedGramSchmidtIR
 export LanczosIterator, ArnoldiIterator, GKLIterator
-export CG, GMRES, BiCGStab, Lanczos, BlockLanczos, Arnoldi, GKL, GolubYe, LSMR
+export CG, GMRES, BiCGStab, Lanczos, Arnoldi, GKL, GolubYe, LSMR
 export KrylovDefaults, EigSorter
 export RecursiveVec, InnerProductVec
 

src/algorithms.jl

@@ -124,10 +124,6 @@ function Lanczos(;
                  orth::Orthogonalizer=KrylovDefaults.orth,
                  eager::Bool=false,
                  verbosity::Int=KrylovDefaults.verbosity[])
-    if block_size >1
-        orth = ModifiedGramSchmidt2()
-        krylovdim = typemax(Int64)
-    end
     return Lanczos(block_size, orth, krylovdim, maxiter, tol, eager, verbosity)
 end
 

src/eigsolve/lanczos.jl

@@ -230,6 +230,12 @@ function block_lanczos_reortho(A, x₀::AbstractMatrix{S}, howmany::Int, which::
             _res(fact, A, howmany, tol, block_size)
     end
 
+    if (fact.k * block_size > alg.krylovdim)
+        @warn "The real Krylov dimension is $(fact.k * block_size), which is larger than the maximum allowed dimension $(alg.krylovdim)."
+        # In this version we don't shrink the factorization because it might cause issues, different from the ordinary Lanczos.
+        # Why it happens remains to be investigated.
+    end
+
     if (num_converged < howmany) && verbosity >= WARN_LEVEL
         @warn """Block Lanczos eigsolve stopped without full convergence after $(fact.k) iterations:
         * $num_converged eigenvalues converged