Merge pull request #4791 from LibreSign/feat/add-group-activity

feat: add group activity

Author: samuelsonbrito

appinfo/info.xml

@@ -71,7 +71,7 @@ Developed with ❤️ by [LibreCode](https://librecode.coop). Help us transform
     </settings>
     <activity>
         <settings>
-            <setting>OCA\Libresign\Activity\FileToSign</setting>
+            <setting>OCA\Libresign\Activity\Settings\FileToSign</setting>
         </settings>
         <filters>
             <filter>OCA\Libresign\Activity\Filter</filter>

lib/Activity/Settings/FileToSign.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+/**
+ * SPDX-FileCopyrightText: 2025 LibreCode coop and contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Libresign\Activity\Settings;
+
+use OCP\IL10N;
+
+class FileToSign extends LibresignActivitySettings {
+	public function __construct(
+		protected IL10N $l,
+	) {
+	}
+
+	/**
+	 * @return string Lowercase a-z and underscore only identifier. The type of table activity
+	 * @since 20.0.0
+	 */
+	public function getIdentifier(): string {
+		return 'file_to_sign';
+	}
+
+	/**
+	 * @return string A translated string
+	 * @since 11.0.0
+	 */
+	public function getName(): string {
+		return $this->l->t('You have a <strong>file to sign</strong>');
+	}
+}

lib/Activity/FileToSign.php renamed to lib/Activity/Settings/LibresignActivitySettings.php

@@ -1,50 +1,29 @@
 <?php
 
 declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2020-2024 LibreCode coop and contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-
-namespace OCA\Libresign\Activity;
+namespace OCA\Libresign\Activity\Settings;
 
 use OCP\Activity\ActivitySettings;
-use OCP\IL10N;
-
-class FileToSign extends ActivitySettings {
-	public function __construct(
-		protected IL10N $l,
-	) {
-	}
 
-	/**
-	 * @return string Lowercase a-z and underscore only identifier. The type of table activity
-	 * @since 20.0.0
-	 */
-	public function getIdentifier(): string {
-		return 'file_to_sign';
-	}
-
-	/**
-	 * @return string A translated string
-	 * @since 11.0.0
-	 */
-	public function getName(): string {
-		return $this->l->t('You have a <strong>file to sign</strong>');
-	}
+abstract class LibresignActivitySettings extends ActivitySettings {
 
 	/**
 	 * {@inheritdoc}
 	 */
-	public function getGroupIdentifier(): string {
-		return 'other';
+	public function getGroupIdentifier() {
+		return 'libresign';
 	}
 
 	/**
 	 * {@inheritdoc}
 	 */
-	public function getGroupName(): string {
-		return $this->l->t('Other activities');
+	public function getGroupName() {
+		return 'LibreSign';
 	}
 
 	/**