Skip to content

Commit 993460a

Browse files
committed
OpenTelemetry bug fix
1 parent 2ec793b commit 993460a

File tree

4 files changed

+16
-10
lines changed

4 files changed

+16
-10
lines changed

Readme.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,8 +543,7 @@ Integrate OpenTelemetry for observability, including metrics, traces, and loggin
543543
To configure the OTLP exporter, ensure the following entries are present in your appsettings{Environment}.json or as environment variables:
544544
```json
545545
{
546-
"OTEL_EXPORTER_OTLP_ENDPOINT": "http://localhost:4317",
547-
"OTEL_SERVICE_NAME": "OTLP-Example"
546+
"OTEL_EXPORTER_OTLP_ENDPOINT": "http://localhost:4317"
548547
}
549548
```
550549
4. Included Features:

SharedKernel.sln.DotSettings

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
22
<s:Boolean x:Key="/Default/UserDictionary/Words/=mediat/@EntryIndexedValue">True</s:Boolean>
3+
<s:Boolean x:Key="/Default/UserDictionary/Words/=otlp/@EntryIndexedValue">True</s:Boolean>
34
<s:Boolean x:Key="/Default/UserDictionary/Words/=sharedkernel/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>

src/SharedKernel/Extensions/OpenTelemetryExtension.cs

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,31 @@ public static WebApplicationBuilder AddOpenTelemetry(this WebApplicationBuilder
2424

2525
builder.Services
2626
.AddOpenTelemetry()
27-
.UseOtlpExporter()
2827
.ConfigureResource(resource => resource.AddService(builder.Environment.ApplicationName))
2928
.WithMetrics(metrics =>
3029
{
3130
metrics.AddRuntimeInstrumentation()
3231
.AddAspNetCoreInstrumentation()
3332
.AddHttpClientInstrumentation()
34-
.AddPrometheusExporter()
35-
.AddOtlpExporter();
33+
.AddPrometheusExporter();
3634
})
3735
.WithTracing(tracing =>
3836
{
3937
tracing.AddAspNetCoreInstrumentation()
4038
.AddHttpClientInstrumentation()
41-
.AddEntityFrameworkCoreInstrumentation()
42-
.AddOtlpExporter();
39+
.AddEntityFrameworkCoreInstrumentation();
4340
});
41+
42+
var otlpEnabled = !string.IsNullOrEmpty(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);
4443

45-
builder.Logging.AddOpenTelemetry(logging => logging.AddOtlpExporter());
44+
if (!otlpEnabled)
45+
{
46+
return builder;
47+
}
48+
49+
builder.Services.ConfigureOpenTelemetryLoggerProvider(l => l.AddOtlpExporter());
50+
builder.Services.ConfigureOpenTelemetryTracerProvider(t => t.AddOtlpExporter());
51+
builder.Services.ConfigureOpenTelemetryTracerProvider(t => t.AddOtlpExporter());
4652

4753
return builder;
4854
}

src/SharedKernel/SharedKernel.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
<PackageReadmeFile>Readme.md</PackageReadmeFile>
99
<Authors>Pandatech</Authors>
1010
<Copyright>MIT</Copyright>
11-
<Version>1.0.14</Version>
11+
<Version>1.0.15</Version>
1212
<PackageId>Pandatech.SharedKernel</PackageId>
1313
<Title>Pandatech Shared Kernel Library</Title>
1414
<PackageTags>Pandatech, shared kernel, library, OpenAPI, Swagger, utilities, scalar</PackageTags>
1515
<Description>Pandatech.SharedKernel provides centralized configurations, utilities, and extensions for ASP.NET Core projects. For more information refere to readme.md document.</Description>
1616
<RepositoryUrl>https://github.com/PandaTechAM/be-lib-sharedkernel</RepositoryUrl>
17-
<PackageReleaseNotes>OpenTelemetry upgrade</PackageReleaseNotes>
17+
<PackageReleaseNotes>OpenTelemetry bug fix</PackageReleaseNotes>
1818
</PropertyGroup>
1919

2020
<ItemGroup>

0 commit comments

Comments
 (0)