Skip to content

[FEATURE] Update Pipedrive to use Webhooks v2 #16246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewjschuang opened this issue Apr 10, 2025 · 3 comments · Fixed by #16297
Closed

[FEATURE] Update Pipedrive to use Webhooks v2 #16246

andrewjschuang opened this issue Apr 10, 2025 · 3 comments · Fixed by #16297
Assignees
Labels
enhancement New feature or request

Comments

@andrewjschuang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Our webhooks triggers were using v1, but after Pipedrive updated the default Webhooks API to v2, they stopped working for some reason. I pinned them to use v1 to unblock a customer, but we should update them to use v2 especially before they get deprecated / unusable.

See #16245.

Some other APIs are also using v1, I did not verify if they need to also be updated.

@andrewjschuang andrewjschuang added the enhancement New feature or request label Apr 10, 2025
@luancazarine luancazarine moved this from Prioritized to Doing in Component (Source and Action) Backlog Apr 10, 2025
luancazarine added a commit that referenced this issue Apr 15, 2025
Sources
 - New Deal (Instant)
 - New Person (Instant)
 - New Deal Updated (Instant)
 - New Person Updated (Instant)
@luancazarine luancazarine linked a pull request Apr 15, 2025 that will close this issue
@luancazarine luancazarine moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Apr 15, 2025
@lcaresia lcaresia moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Apr 17, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Apr 18, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog Apr 18, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Apr 18, 2025
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Apr 18, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/FEATURE-Update-Pipedrive-to-use-Webhooks-v2-1d8bf548bb5e81aabbd5c29d920e7057

@luancazarine
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/FEATURE-Update-Pipedrive-to-use-Webhooks-v2-1d8bf548bb5e81aabbd5c29d920e7057

Hi @vunguyenhung , I couldn't reproduce those errors

Image

Image

Image

Image

If you want I can send you my credentials

@luancazarine luancazarine moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Apr 21, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Apr 22, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Apr 22, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/FEATURE-Update-Pipedrive-to-use-Webhooks-v2-1d8bf548bb5e81aabbd5c29d920e7057

luancazarine added a commit that referenced this issue Apr 22, 2025
* [FEATURE] Update Pipedrive to use Webhooks v2 #16246
Sources
 - New Deal (Instant)
 - New Person (Instant)
 - New Deal Updated (Instant)
 - New Person Updated (Instant)

* pnpm update

* change source name

* pnpm update
@github-project-automation github-project-automation bot moved this from Ready for Release to Done in Component (Source and Action) Backlog Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants