Skip to content

Use getDestination from SAP Cloud SDK to avoid direct visibility of credentials #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregorwolf opened this issue Sep 15, 2022 · 0 comments
Assignees

Comments

@gregorwolf
Copy link

Hello @anbazhagan-uma, @ajinkyapatil8190 and @pra1veenk,

thank you for the effort that went into this sample application. I would suggest this improvement:

As I can see server/services/S4HANAClient.js you've already using the great SAP Cloud SDK with it's executeHttpRequest to call the S/4HANA backend. But you're storing the credentials for the Microsoft Graph in Environment variables. I would suggest to store them in a destination and get them using getDestination from the SAP Cloud SDK?

Best Regards
Gregor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants