Fix #49 - Added new rule G-4365: Never use unconditional CONTINUE or EXIT in a loop.

Author: kibeha

docs/4-language-usage/4-control-structures/3-flow-control/g-4365.md

@@ -0,0 +1,42 @@
+# G-4365: Never use unconditional CONTINUE or EXIT in a loop.
+
+!!! warning "Major"
+    Maintainability, Testability
+
+## Reason
+
+An unconditional `continue` is either redundant (a `continue` as the last statement before the end of the loop) or causes dead code. An unconditional `exit` causes no looping and may cause dead code as well. If `continue` or `exit` is needed, it should always have a condition.
+
+## Example (bad)
+
+``` sql
+begin
+   <<process_employees>>
+   loop
+      my_package.some_processing();
+
+      continue process_employees;
+
+      my_package.some_further_processing(); -- Dead code
+   end loop process_employees;
+end;
+/
+```
+
+## Example (good)
+
+``` sql
+declare
+   co_first_year constant pls_integer := 1900;
+begin
+   <<process_employees>>
+   loop
+      my_package.some_processing();
+
+      continue process_employees when extract(year from sysdate) > co_first_year;
+
+      my_package.some_further_processing();
+   end loop process_employees;
+end;
+/
+```

docs/9-appendix/appendix.md

@@ -78,6 +78,7 @@ n/a | 4325 | Never reuse labels in inner scopes. | Major |  |  | ✘ |  | &
 42 | 4340 | Always use a NUMERIC FOR loop to process a dense array. | Minor |  |  | ✘ |  |  |  |  | 
 43 | 4350 | Always use 1 as lower and COUNT() as upper bound when looping through a dense array.  | Major |  |  |  |  | ✘ |  |  | 
 44 | 4360 | Always use a WHILE loop to process a loose array. | Minor |  | ✘ |  |  |  |  |  | 
+n/a | 4365 | Never use unconditional CONTINUE or EXIT in a loop. | Major |  |  | ✘ |  |  |  |  | ✘
 45 | 4370 | Avoid using EXIT to stop loop processing unless you are in a basic loop. | Major |  |  | ✘ |  |  |  |  | 
 46 | 4375 | Always use EXIT WHEN instead of an IF statement to exit from a loop.  | Minor |  |  | ✘ |  |  |  |  | 
 47 | 4380 | Try to label your EXIT WHEN statements. | Minor |  |  | ✘ |  |  |  |  |