Add support for preferences from MeshSimplifiers via IPreferences (resolves #7); Update UnityMeshSimplifier to latest

Author: amirebrahimi

Packages/UnityMeshSimplifier

@@ -173,6 +173,7 @@ static List<Type> batchers
         static SceneLOD s_SceneLOD;
         static List<Type> s_MeshSimplifiers;
         static List<Type> s_Batchers;
+        static IPreferences s_SimplifierPreferences;
 
         static void UpdateDependencies()
         {
@@ -642,7 +643,6 @@ static void PreferencesGUI()
                     var maxTime = EditorGUILayout.IntSlider(label, maxExecutionTime, 0, 15);
                     if (EditorGUI.EndChangeCheck())
                         maxExecutionTime = maxTime;
-
                 }
             }
 
@@ -661,6 +661,19 @@ static void PreferencesGUI()
                     var selected = EditorGUILayout.Popup(label, Array.IndexOf(displayedOptions, type.Name), displayedOptions);
                     if (EditorGUI.EndChangeCheck())
                         meshSimplifierType = meshSimplifiers[selected];
+
+                    if (meshSimplifierType != null && typeof(IMeshSimplifier).IsAssignableFrom(meshSimplifierType))
+                    {
+                        if (s_SimplifierPreferences == null || s_SimplifierPreferences.GetType() != meshSimplifierType)
+                            s_SimplifierPreferences = (IPreferences)Activator.CreateInstance(meshSimplifierType);
+
+                        if (s_SimplifierPreferences != null)
+                        {
+                            EditorGUI.indentLevel++;
+                            s_SimplifierPreferences.OnPreferencesGUI();
+                            EditorGUI.indentLevel--;
+                        }
+                    }
                 }
                 else
                 {

Scripts/Editor/AutoLOD.cs

@@ -1,5 +1,6 @@
 #if ENABLE_UNITYMESHSIMPLIFIER
-using Unity.AutoLOD;
+using System;
+using UnityEditor;
 using UnityEngine;
 using UnityMeshSimplifier;
 using Mesh = Unity.AutoLOD.WorkingMesh;
@@ -12,11 +13,64 @@
 #if ENABLE_UNITYMESHSIMPLIFIER
 namespace Unity.AutoLOD
 {
-    public struct QuadricMeshSimplifier : IMeshSimplifier
+    public struct QuadricMeshSimplifier : IMeshSimplifier, IPreferences
     {
+        [InitializeOnLoad]
+        class Preferences : ScriptableSingleton<Preferences>
+        {
+            const string k_Options = "AutoLOD.QuadricMeshSimplifier.Options";
+
+            public static SimplificationOptions Options;
+
+            // Needed for SerializedObject/SerializedProperty
+            [SerializeField]
+            internal SimplificationOptions m_Options;
+
+            // Load the options statically, so they can be used in jobs
+            static Preferences()
+            {
+                EditorApplication.delayCall += () =>
+                {
+                    var preferences = Preferences.instance;
+                    Debug.Assert(!preferences.Equals(default), "QuadricMeshSimplifier preferences should never be the default struct");
+                };
+            }
+
+            void OnEnable()
+            {
+                // It's okay that it doesn't save, but don't hide it otherwise the inspector GUI won't work
+                hideFlags = HideFlags.DontSave;
+
+                var savedPrefs = EditorPrefs.GetString(k_Options, null);
+                if (string.IsNullOrEmpty(savedPrefs))
+                    m_Options = SimplificationOptions.Default;
+                else
+                    m_Options = JsonUtility.FromJson<SimplificationOptions>(savedPrefs);
+
+                // Update the static version
+                Options = m_Options;
+            }
+
+            public void ResetToDefaults()
+            {
+                m_Options = SimplificationOptions.Default;
+                Save();
+            }
+
+            public void Save()
+            {
+                var savedPrefs = JsonUtility.ToJson(m_Options);
+                EditorPrefs.SetString(k_Options, savedPrefs);
+                Options = m_Options;
+            }
+        }
+
+        SerializedObject m_SerializedObject;
+
         public void Simplify(Mesh inputMesh, Mesh outputMesh, float quality)
         {
             var meshSimplifier = new MeshSimplifier();
+            meshSimplifier.SimplificationOptions = Preferences.Options;
             meshSimplifier.Vertices = inputMesh.vertices;
             meshSimplifier.Normals = inputMesh.normals;
             meshSimplifier.Tangents = inputMesh.tangents;
@@ -50,6 +104,50 @@ public void Simplify(Mesh inputMesh, Mesh outputMesh, float quality)
             }
         }
 
+        public void OnPreferencesGUI()
+        {
+            var preferences = Preferences.instance;
+            if (m_SerializedObject == null)
+                m_SerializedObject = new SerializedObject(preferences);
+
+            m_SerializedObject.Update();
+            var property = m_SerializedObject.FindProperty("m_Options");
+
+            EditorGUI.BeginChangeCheck();
+
+            EditorGUILayout.BeginHorizontal();
+            EditorGUILayout.PropertyField(property);
+            if (property.isExpanded)
+            {
+                GUI.enabled = !preferences.m_Options.Equals(SimplificationOptions.Default);
+                if (GUILayout.Button("Reset", EditorStyles.miniButton, GUILayout.ExpandWidth(false)))
+                {
+                    preferences.ResetToDefaults();
+                    EditorGUIUtility.ExitGUI();
+                }
+                GUI.enabled = true;
+            }
+            EditorGUILayout.EndHorizontal();
+            if (property.isExpanded)
+            {
+                EditorGUI.indentLevel++;
+                property.NextVisible(true);
+                do
+                {
+                    EditorGUILayout.BeginHorizontal();
+                    EditorGUILayout.LabelField(property.name, GUILayout.Width(200f));
+                    EditorGUILayout.PropertyField(property, GUIContent.none, true, GUILayout.ExpandWidth(false));
+                    EditorGUILayout.EndHorizontal();
+                } while (property.NextVisible(false));
+                EditorGUI.indentLevel--;
+            }
+
+            if (EditorGUI.EndChangeCheck())
+            {
+                m_SerializedObject.ApplyModifiedProperties();
+                preferences.Save();
+            }
+        }
     }
 }
 #endif

Scripts/Editor/MeshSimplifiers/QuadricMeshSimplifier.cs

@@ -0,0 +1,11 @@
+namespace Unity.AutoLOD
+{
+    public interface IPreferences
+    {
+        /// <summary>
+        /// Callback from AutoLOD preferences GUI to show GUI options related to a simplifier / batcher.
+        /// Settings should be saved here as well and also utilized by the simplifier / batcher.
+        /// </summary>
+        void OnPreferencesGUI();
+    }
+}