Skip to content

Commit 3337a75

Browse files
authored
feat: Project header added to every request (#81)
* feat: Project header added to every request
1 parent cf721b1 commit 3337a75

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

build.gradle

+6-6
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ buildscript {
2525
}
2626

2727
dependencies {
28-
implementation 'com.google.code.gson:gson:2.8.6'
28+
implementation 'com.google.code.gson:gson:2.9.0'
2929
implementation group: 'ch.qos.logback', name: 'logback-classic', version: '1.2.3'
30-
testImplementation group: 'org.testng', name: 'testng', version: '7.3.0'
31-
testImplementation 'commons-io:commons-io:2.7'
32-
testImplementation 'org.mockito:mockito-core:3.5.13'
33-
testImplementation "com.squareup.okhttp3:mockwebserver:4.8.1"
30+
testImplementation group: 'org.testng', name: 'testng', version: '7.5'
31+
testImplementation 'commons-io:commons-io:2.11.0'
32+
testImplementation 'org.mockito:mockito-core:4.4.0'
33+
testImplementation 'com.squareup.okhttp3:mockwebserver:4.9.3'
3434
}
3535

3636
test {
@@ -45,4 +45,4 @@ jacocoTestReport {
4545
}
4646
}
4747

48-
check.dependsOn jacocoTestReport
48+
check.dependsOn jacocoTestReport

src/main/java/io/visual_regression_tracker/sdk_java/VisualRegressionTracker.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public class VisualRegressionTracker {
2525

2626
private static final String TRACKER_NOT_STARTED = "Visual Regression Tracker has not been started";
2727
protected static final String API_KEY_HEADER = "apiKey";
28+
protected static final String PROJECT_HEADER = "project";
2829
protected Gson gson;
2930
protected VisualRegressionTrackerConfig configuration;
3031
protected PathProvider paths;
@@ -56,7 +57,7 @@ public BuildResponse start() throws IOException, InterruptedException {
5657
projectId = buildResponse.getProjectId();
5758

5859
log.info("Visual Regression Tracker is started for project <{}>: projectId: <{}>, buildId: <{}>, ciBuildId: <{}>",
59-
projectName, projectId, buildId, buildResponse.getCiBuildId());
60+
projectName, projectId, buildId, buildResponse.getCiBuildId());
6061
return buildResponse;
6162
}
6263

@@ -142,6 +143,7 @@ private HttpResponse<String> getResponse(METHOD method, String url, HttpRequest.
142143
HttpRequest.Builder requestBuilder = HttpRequest.newBuilder()
143144
.timeout(Duration.ofSeconds(configuration.getHttpTimeoutInSeconds()))
144145
.header(API_KEY_HEADER, configuration.getApiKey())
146+
.header(PROJECT_HEADER, configuration.getProject())
145147
.header("Content-Type", "application/json;charset=UTF-8")
146148
.uri(URI.create(url));
147149
HttpRequest request = getRequest(method, body, requestBuilder);

src/test/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerTest.java

+3
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ public void shouldStartBuild() throws IOException, InterruptedException {
102102

103103
RecordedRequest recordedRequest = mockWebServer.takeRequest();
104104
assertThat(recordedRequest.getHeader(VisualRegressionTracker.API_KEY_HEADER), is(config.getApiKey()));
105+
assertThat(recordedRequest.getHeader(VisualRegressionTracker.PROJECT_HEADER), is(config.getProject()));
105106
assertThat(recordedRequest.getBody().readUtf8(), is(gson.toJson(buildRequest)));
106107
assertThat(vrt.buildId, is(BUILD_ID));
107108
assertThat(vrt.projectId, is(PROJECT_ID));
@@ -130,6 +131,7 @@ public void shouldStopBuild() throws IOException, InterruptedException {
130131
RecordedRequest recordedRequest = mockWebServer.takeRequest();
131132
assertThat(recordedRequest.getMethod(), is("PATCH"));
132133
assertThat(recordedRequest.getHeader(VisualRegressionTracker.API_KEY_HEADER), is(config.getApiKey()));
134+
assertThat(recordedRequest.getHeader(VisualRegressionTracker.PROJECT_HEADER), is(config.getProject()));
133135
assertThat(Objects.requireNonNull(recordedRequest.getRequestUrl()).encodedPath(), containsString(BUILD_ID));
134136
assertThat(actualBuildResponse.isRunning(), is(false));
135137
assertThat(actualBuildResponse.getStatus(), containsString("unresolved"));
@@ -184,6 +186,7 @@ public void shouldSubmitTestRun() throws IOException, InterruptedException {
184186

185187
RecordedRequest request = mockWebServer.takeRequest();
186188
assertThat(request.getHeader(VisualRegressionTracker.API_KEY_HEADER), is(config.getApiKey()));
189+
assertThat(request.getHeader(VisualRegressionTracker.PROJECT_HEADER), is(config.getProject()));
187190
assertThat(request.getBody().readUtf8(), is(gson.toJson(testRunRequest)));
188191
assertThat(gson.toJson(result), is(gson.toJson(testRunResponse)));
189192
}

0 commit comments

Comments
 (0)