Skip to content

Commit ff811aa

Browse files
authored
Fix: beginAtZero for logarighmic (chartjs#7899)
1 parent c9b38b6 commit ff811aa

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/scales/scale.logarithmic.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,10 @@ export default class LogarithmicScale extends Scale {
7777
me.min = isFinite(min) ? Math.max(0, min) : null;
7878
me.max = isFinite(max) ? Math.max(0, max) : null;
7979

80+
if (me.options.beginAtZero) {
81+
me._zero = true;
82+
}
83+
8084
me.handleTickRangeOptions();
8185
}
8286

@@ -159,7 +163,6 @@ export default class LogarithmicScale extends Scale {
159163

160164
me._startValue = log10(start);
161165
me._valueRange = log10(me.max) - log10(start);
162-
me._zero = me.options.beginAtZero;
163166
}
164167

165168
getPixelForValue(value) {

test/specs/scale.logarithmic.tests.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ describe('Logarithmic Scale tests', function() {
345345
}
346346
});
347347

348-
expect(chart.scales.y.min).toBe(1);
348+
expect(chart.scales.y.min).toBe(0.1);
349349
expect(chart.scales.y.max).toBe(200);
350350
});
351351

@@ -387,7 +387,7 @@ describe('Logarithmic Scale tests', function() {
387387
}
388388
});
389389

390-
expect(chart.scales.y.min).toBe(1);
390+
expect(chart.scales.y.min).toBe(0.1);
391391
expect(chart.scales.y.max).toBe(200);
392392
});
393393

@@ -517,7 +517,7 @@ describe('Logarithmic Scale tests', function() {
517517
type: 'bar',
518518
data: {
519519
datasets: [{
520-
data: [10, 5, 1, 25, 78]
520+
data: [10, 5, 2, 25, 78]
521521
}],
522522
labels: []
523523
},
@@ -659,7 +659,7 @@ describe('Logarithmic Scale tests', function() {
659659
type: 'bar',
660660
data: {
661661
datasets: [{
662-
data: [10, 5, 1, 25, 78]
662+
data: [10, 5, 2, 25, 78]
663663
}],
664664
labels: []
665665
},

0 commit comments

Comments
 (0)