🐛 Pass clear value in SDKCreatedDto while generating the secret

Author: kevinpiac

console/src/lib/components/project/secret/SDKSecretGenerator.svelte

@@ -3,19 +3,19 @@
 	import { Key } from "svelte-hero-icons";
 	import { generateSecret } from "$lib/usecases/sdk-secrets/generateSecret";
 	import { toastError } from "$lib/utils/toast";
-	import type { SdkSecret } from "$lib/entities/sdk-secret/sdk-secret";
 	import CopiableTag from "$lib/components/common/copiable/CopiableTag.svelte";
 	import { projectStore } from "$lib/stores/project";
 	import Alert from "$lib/components/common/alert/Alert.svelte";
 	import Spacer from "$lib/components/common/spacer/Spacer.svelte";
+	import type { CreatedSdkSecretDto } from "$lib/services/gen-api";
 
 	const project = $projectStore.currentProject;
 
 	if (!project) throw new Error("No project selected");
 
 	let loading = false;
 
-	let generatedSecret: SdkSecret | undefined;
+	let generatedSecret: CreatedSdkSecretDto | undefined;
 	const generate = async () => {
 		try {
 			loading = true;
@@ -39,7 +39,9 @@
 				able to see it again.
 			</div>
 			<Spacer size="sm" />
-			<CopiableTag value={generatedSecret.hash} displayedValue={generatedSecret.preview} />
+			<CopiableTag
+				value={generatedSecret.clearValue}
+				displayedValue={generatedSecret.preview} />
 		</Alert>
 	{/if}
 </div>

console/src/lib/usecases/sdk-secrets/generateSecret.ts

@@ -1,7 +1,7 @@
+import type { CreatedSdkSecretDto } from "$lib/services/gen-api";
 import { SdkSecretsService } from "$lib/services/gen-api";
-import type { SdkSecret } from "$lib/entities/sdk-secret/sdk-secret";
 
-export const generateSecret = async (projectId: string): Promise<SdkSecret> => {
+export const generateSecret = async (projectId: string): Promise<CreatedSdkSecretDto> => {
 	const secret = await SdkSecretsService.create({
 		requestBody: {
 			description: "SDK Secret generated from the console",
@@ -10,8 +10,6 @@ export const generateSecret = async (projectId: string): Promise<SdkSecret> => {
 	});
 
 	return {
-		...secret,
-		createdAt: new Date(secret.createdAt),
-		updatedAt: new Date(secret.updatedAt)
+		...secret
 	};
 };

server/openapi.yaml

@@ -919,7 +919,7 @@ components:
     CreatedSdkSecretDto:
       type: object
       properties:
-        hash:
+        clearValue:
           type: string
         id:
           type: string
@@ -937,7 +937,7 @@ components:
           format: date-time
           type: string
       required:
-        - hash
+        - clearValue
         - id
         - description
         - projectId

server/src/sdk-secrets/dtos/created.sdk-secret.dto.ts

@@ -3,5 +3,5 @@ import { SanitizedSdkSecretDto } from './sanitized.sdk-secret.dto';
 
 export class CreatedSdkSecretDto extends SanitizedSdkSecretDto {
   @IsString()
-  hash: string;
+  clearValue: string;
 }

server/src/sdk-secrets/sdk-secrets.service.ts

@@ -1,7 +1,10 @@
 import { Injectable } from '@nestjs/common';
+import { SdkSecret } from '@prisma/client';
 import { createHash, randomBytes } from 'crypto';
 import { PResult, err, ok } from '../common/result';
 import { PrismaService } from '../prisma/prisma.service';
+import { CreatedSdkSecretDto } from './dtos/created.sdk-secret.dto';
+import { SanitizedSdkSecretDto } from './dtos/sanitized.sdk-secret.dto';
 import { VerifyIfIsProjectUserError } from './sdk-secrets.errors';
 
 @Injectable()
@@ -49,7 +52,21 @@ export class SdkSecretsService {
     return ok({ isVerified: true });
   }
 
-  async createSecret(dto: { projectId: string; creatorId: string }) {
+  private sanitizeSecret(secret: SdkSecret): SanitizedSdkSecretDto {
+    return {
+      id: secret.id,
+      description: secret.description,
+      projectId: secret.projectId,
+      preview: secret.preview,
+      createdAt: secret.createdAt,
+      updatedAt: secret.updatedAt,
+    };
+  }
+
+  async createSecret(dto: {
+    projectId: string;
+    creatorId: string;
+  }): PResult<CreatedSdkSecretDto, VerifyIfIsProjectUserError> {
     const { projectId, creatorId } = dto;
 
     const verifyResult = await this.verifyIfProjectUser({
@@ -82,7 +99,10 @@ export class SdkSecretsService {
       },
     });
 
-    return ok(created);
+    return ok({
+      ...this.sanitizeSecret(created),
+      clearValue: clearSecret,
+    });
   }
 
   async verifySdkSecret(

typescript-client/src/models/CreatedSdkSecretDto.ts

@@ -4,7 +4,7 @@
 /* eslint-disable */
 
 export type CreatedSdkSecretDto = {
-    hash: string;
+    clearValue: string;
     id: string;
     description: string | null;
     projectId: string;