From c8b907b34e082c5a341dfca116224c5d772a573c Mon Sep 17 00:00:00 2001 From: alkavats1 <alka.vats@nashtechglobal.com> Date: Fri, 23 Jun 2023 10:46:25 +0530 Subject: [PATCH] refactor: removed the Unexpected empty object pattern removed the empty object declaration from the collections --- src/compat/firestore/collection-group/collection-group.ts | 2 +- src/compat/firestore/collection/collection.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compat/firestore/collection-group/collection-group.ts b/src/compat/firestore/collection-group/collection-group.ts index 06162ed13..b7354753f 100644 --- a/src/compat/firestore/collection-group/collection-group.ts +++ b/src/compat/firestore/collection-group/collection-group.ts @@ -83,7 +83,7 @@ export class AngularFirestoreCollectionGroup<T = DocumentData> { */ valueChanges(): Observable<T[]>; // tslint:disable-next-line:unified-signatures - valueChanges({}): Observable<T[]>; + valueChanges(): Observable<T[]>; valueChanges<K extends string>(options: {idField: K}): Observable<(T & { [T in K]: string })[]>; valueChanges<K extends string>(options: {idField?: K} = {}): Observable<T[]> { const fromCollectionRefScheduled$ = fromCollectionRef<T>(this.query, this.afs.schedulers.outsideAngular); diff --git a/src/compat/firestore/collection/collection.ts b/src/compat/firestore/collection/collection.ts index f873441ad..26c93e3db 100644 --- a/src/compat/firestore/collection/collection.ts +++ b/src/compat/firestore/collection/collection.ts @@ -105,7 +105,7 @@ export class AngularFirestoreCollection<T = DocumentData> { */ valueChanges(): Observable<T[]>; // tslint:disable-next-line:unified-signatures - valueChanges({}): Observable<T[]>; + valueChanges(): Observable<T[]>; valueChanges<K extends string>(options: {idField: K}): Observable<(T & { [T in K]: string })[]>; valueChanges<K extends string>(options: {idField?: K} = {}): Observable<T[]> { return fromCollectionRef<T>(this.query, this.afs.schedulers.outsideAngular)