Advance doc instead of offset in competitive iterator (#14530)

Author: gf2121

lucene/CHANGES.txt

@@ -11,7 +11,7 @@ Bug Fixes
 * GITHUB#14522: Fix DISIDocIdStream::count so that it does not try to count beyond max.
   (Chris Hegarty)
 
-* GITHUB#14523: Correct TermOrdValComparator competitive iterator so that it forces sparse
+* GITHUB#14523, GITHUB#14530: Correct TermOrdValComparator competitive iterator so that it forces sparse
   field iteration to be at least scoring window baseline when doing intoBitSet. (Ben Trent, Adrien Grand)
 
 ======================= Lucene 10.2.0 =======================

lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java

@@ -538,8 +538,8 @@ public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws IOExcept
       if (disjunction == null) {
         if (docsWithField != null) {
           // we need to be absolutely sure that the iterator is at least at offset
-          if (docsWithField.docID() < offset) {
-            docsWithField.advance(offset);
+          if (docsWithField.docID() < doc) {
+            docsWithField.advance(doc);
           }
           docsWithField.intoBitSet(upTo, bitSet, offset);
           doc = docsWithField.docID();