fflib_SObjectSelectorTest not compatible with Force.com orgs (here: UE)

[ragoergens]

Describe the bug
Tried to deploy the FormulaShare package (AppExchange ID: a0N3A00000FR5TCUA1) into a Force.com Unlimited Edition sandbox. This org type does not have a Marketing User license provisioned.

Installation fails with:

This package can’t be installed.
There are problems that prevent this package from being installed.
ApexClass Variable does not exist: CampaignMember
fflib_SObjectSelectorTest: Variable does not exist: CampaignMember

To Reproduce
Requires access to a Force.com-only org (rare license type).

Steps to reproduce the behavior:

1. From https://appexchange.salesforce.com/appxListingDetail?listingId=a0N3A00000FR5TCUA1, select 'Try It', then install into a Force.com-only org.
2. Package install fails.
3. See above error.

Expected behavior
Ideally, fflib would not have a dependency on the CampaignMember (or Campaign) objects, so that dependent packages can be used on Force.com-only orgs that don't have a Marketing User license provisioned.

Screenshots and text of error observed
This package can’t be installed.
There are problems that prevent this package from being installed.
ApexClass Variable does not exist: CampaignMember
fflib_SObjectSelectorTest: Variable does not exist: CampaignMember

Version
FormulaShare 4.3 (latest)

[LawrenceLoz]

Lawrence from Cloud Sundial (FormulaShare) here.

We're using the current version of fflibs without modification in our package - as @ragoergens outlines this error prevents installation in orgs without this license.

From a brief look at the the affected class it seems like the tests using CampaignMember/Lead could be replaced with ones referencing Contact/Account to allow for checking related field selector behaviour using objects which should exist in every org. This is the only reference to CampaignMember in apex-common so hopefully this is enough.

I'm happy to try to make this change and submit a PR if this feels like the right thing to do?

[daveespo]

Some of the test methods that were written for CampaignMember are exercising the polymorphic relationship code. See the PR #402 where they were added.

If you see a path to us Contact/Account/Lead to implement those same test cases, that is a PR we'd definitely be willing to merge.

I will acknowledge that this is not the first time a license issue has caused issues with test coverage in the AEP (fflib) projects. It's a mine field to try to write realistic (i.e. reliable) test methods. We try to use objects in Sales Cloud only -- but we've even hit snags with some of those object (#503 which resulted in #506 to fix it). Knowing which objects are actually universally reachable is black magic.

[LawrenceLoz]

@daveespo gotcha - thanks for the context. Useful to know it's the polymorphic relationship from Lead which led to the inclusion of CampaignMember. I'm guessing then the key is find objects where we can test a selector which queries fields from the polymorphic parent of an object related by a lookup (e.g. querying Lead.Owner.UserRoleId from CampaignMember).

I'll have a look in more detail and try to think of a way to do something similar with other Sales Cloud objects. I can appreciate it's tricky trying to find objects which exist in every Salesforce org out there!

[LawrenceLoz]

@daveespo see #509 for suggested fix.

This replaces use of CampaignMember and Lead with CaseComment and Case respectively, and uses the polymorphic OwnerId field on Case in a similar way to use of OwnerId on Lead previously. Case (and fairly sure CaseComment too) is provided in Sales Cloud even without Service Cloud, and I think should be available in every edition. I've checked this in a Sales Cloud org without Service Cloud licenses and was able to deploy the code locally and run the test successfully.

Hopefully this looks like it achieves the aim of the tests with more universal objects?

If this broadly looks OK then @ragoergens and I could work together to check after changing to this version in our package that this is installable in a Force.com Unlimited Edition sandbox prior to merging here.

Let me know if you think anything more is needed in terms of testing, or if any concerns using Case and CaseComment.

[ragoergens]

@LawrenceLoz great!

I confirm that I can query Case objects in the Force.com Unlimited Edition org, whereas I cannot query Campaign objects.

[daveespo]

Thank you @LawrenceLoz !

[LawrenceLoz]

Thanks @daveespo for reviewing, and for all your and others' great work on this project.

And thanks @ragoergens for identifying and raising the issue!