Skip to content

Commit f86f826

Browse files
janbuchardanpoletaevB4nan
authored
chore: Update Crawlee and fix related issues (#373)
* fix: CI * Fix PlatformEventManager test * Lint * Update test/apify/events.test.ts Co-authored-by: Martin Adámek <banan23@gmail.com> --------- Co-authored-by: Daniil Poletaev <44584010+danpoletaev@users.noreply.github.com> Co-authored-by: Martin Adámek <banan23@gmail.com>
1 parent 0e82b08 commit f86f826

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

packages/actor-scraper/puppeteer-scraper/src/internals/crawler_setup.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export class CrawlerSetup implements CrawlerSetupOptions {
185185
launchContext: {
186186
useChrome: this.input.useChrome,
187187
launchOptions: {
188-
ignoreHTTPSErrors: this.input.ignoreSslErrors,
188+
acceptInsecureCerts: this.input.ignoreSslErrors,
189189
defaultViewport: DEFAULT_VIEWPORT,
190190
devtools: this.devtools,
191191
args,

packages/actor-scraper/web-scraper/src/internals/crawler_setup.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ export class CrawlerSetup implements CrawlerSetupOptions {
228228
launchContext: {
229229
useChrome: this.input.useChrome,
230230
launchOptions: {
231-
ignoreHTTPSErrors: this.input.ignoreSslErrors,
231+
acceptInsecureCerts: this.input.ignoreSslErrors,
232232
defaultViewport: DEFAULT_VIEWPORT,
233233
args,
234234
headless: this.input.headless,

packages/apify/src/proxy_configuration.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ export class ProxyConfiguration extends CoreProxyConfiguration {
305305
return this._handleTieredUrl(
306306
sessionId ?? cryptoRandomObjectId(6),
307307
options,
308-
).proxyUrl;
308+
).proxyUrl ?? undefined;
309309
}
310310

311311
return this.composeDefaultUrl(sessionId);

test/apify/events.test.ts

+9-5
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,13 @@ import { WebSocketServer } from 'ws';
88
describe('events', () => {
99
let wss: WebSocketServer = null;
1010
const config = Configuration.getGlobalConfig();
11-
const events = new PlatformEventManager(config);
12-
config.useEventManager(events);
11+
let events: PlatformEventManager | null = null;
1312

1413
beforeEach(() => {
1514
wss = new WebSocketServer({ port: 9099 });
15+
events = new PlatformEventManager(config);
16+
config.useEventManager(events);
17+
1618
vitest.useFakeTimers();
1719
process.env[ACTOR_ENV_VARS.EVENTS_WEBSOCKET_URL] = 'ws://localhost:9099/someRunId';
1820
process.env[APIFY_ENV_VARS.TOKEN] = 'dummy';
@@ -112,11 +114,13 @@ describe('events', () => {
112114

113115
test('should send persist state events in regular interval', async () => {
114116
const eventsReceived = [];
117+
const interval = config.get('persistStateIntervalMillis');
118+
115119
events.on(EventType.PERSIST_STATE, (data) => eventsReceived.push(data));
116120
await events.init();
117-
vitest.advanceTimersByTime(60001);
118-
vitest.advanceTimersByTime(60001);
119-
vitest.advanceTimersByTime(60001);
121+
await vitest.advanceTimersByTimeAsync(1.1 * interval);
122+
await vitest.advanceTimersByTimeAsync(1.1 * interval);
123+
await vitest.advanceTimersByTimeAsync(1.1 * interval);
120124
await events.close();
121125
expect(eventsReceived.length).toBe(5);
122126
});

0 commit comments

Comments
 (0)