Skip to content

Commit 5d47076

Browse files
committed
Move label and icon registration for copy serial
Moves the registration of the label and icon for the copy output button of the serial monitor to the toolbar item registration. Before, it happened at the command registration, but is not necessary at this level, as the icon and label are meant for the toolbar button only.
1 parent 5033769 commit 5d47076

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

arduino-ide-extension/src/browser/serial/monitor/monitor-view-contribution.tsx

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,9 @@ export namespace SerialMonitor {
5252
},
5353
'vscode/output.contribution/clearOutput.label'
5454
);
55-
export const COPY_OUTPUT = Command.toLocalizedCommand(
56-
{
57-
id: 'serial-monitor-copy-output',
58-
label: 'Copy Output',
59-
iconClass: codicon('copy'),
60-
},
61-
'arduino/serial/copyOutput'
62-
);
55+
export const COPY_OUTPUT = {
56+
id: 'serial-monitor-copy-output',
57+
};
6358
}
6459
}
6560

@@ -160,10 +155,8 @@ export class MonitorViewContribution
160155
registry.registerItem({
161156
id: SerialMonitor.Commands.COPY_OUTPUT.id,
162157
command: SerialMonitor.Commands.COPY_OUTPUT.id,
163-
tooltip: nls.localize(
164-
'arduino/serial/copyOutput',
165-
'Copy Output'
166-
),
158+
icon: codicon('copy'),
159+
tooltip: nls.localize('arduino/serial/copyOutput', 'Copy Output'),
167160
});
168161
}
169162

0 commit comments

Comments
 (0)