Fix Clock being null (#299)

Author: SentryMan

blackbox-test/src/main/java/example/avaje/clock/Clocky.java

@@ -0,0 +1,9 @@
+package example.avaje.clock;
+
+import java.time.LocalDate;
+
+import io.avaje.validation.constraints.Future;
+import io.avaje.validation.constraints.Valid;
+
+@Valid
+public record Clocky(@Future LocalDate startDate) {}

blackbox-test/src/test/java/example/avaje/clock/ClockTest.java

@@ -0,0 +1,40 @@
+package example.avaje.clock;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
+
+import java.time.LocalDate;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Locale;
+
+import org.junit.jupiter.api.Test;
+
+import io.avaje.validation.ConstraintViolation;
+import io.avaje.validation.ConstraintViolationException;
+import io.avaje.validation.Validator;
+
+class ClockTest {
+
+  Validator validator = Validator.builder().build();
+
+  @Test
+  void valid() {
+    var ship = new Clocky(LocalDate.MIN);
+    assertThat(violations(ship)).hasSize(1);
+  }
+
+  List<ConstraintViolation> violations(Object any) {
+    return violations(any, Locale.ENGLISH);
+  }
+
+  List<ConstraintViolation> violations(Object any, Locale locale) {
+    try {
+      validator.validate(any, locale);
+      fail("not expected");
+      return null;
+    } catch (ConstraintViolationException e) {
+      return new ArrayList<>(e.violations());
+    }
+  }
+}

validator/src/main/java/io/avaje/validation/core/DValidator.java

@@ -180,8 +180,8 @@ String interpolate(Message msg, Locale requestLocale) {
   /** Implementation of Validator.Builder. */
   static final class DBuilder implements Validator.Builder {
 
-    private static final Validator DEFAULT = Validator.builder().build();
     private static final Supplier<Clock> DEFAULT_CLOCK = Clock::systemDefaultZone;
+    private static final Validator DEFAULT = Validator.builder().build();
 
     private final List<AdapterFactory> factories = new ArrayList<>();
     private final List<AnnotationFactory> afactories = new ArrayList<>();