FIXED: Build breaks because of the nullable Error parameters detected by the TypeScript compiler.

Author: balassy

shared/api.interfaces.ts

@@ -1,11 +1,11 @@
-import { APIGatewayEvent, Context, ProxyCallback, ProxyHandler, ProxyResult } from 'aws-lambda';  // tslint:disable-line no-implicit-dependencies (Using only the type information from the @types package.)
+import { APIGatewayEvent, Context, ProxyCallback, ProxyResult } from 'aws-lambda';  // tslint:disable-line no-implicit-dependencies (Using only the type information from the @types package.)
 import { ErrorResult } from './errors';
 
 // Type aliases to hide the 'aws-lambda' package and have consistent, short naming.
 export type ApiCallback = ProxyCallback;
 export type ApiContext = Context;
 export type ApiEvent = APIGatewayEvent;
-export type ApiHandler = ProxyHandler;
+export type ApiHandler = (event: APIGatewayEvent, context: Context, callback: ApiCallback) => void; // Same as ProxyHandler, but requires callback.
 export type ApiResponse = ProxyResult;
 
 export interface ErrorResponseBody {

src/health/health.controller.spec.ts

@@ -68,7 +68,7 @@ describe('HealthController', () => {
           };
         }
 
-        handler(event, <ApiContext> {}, (error?: Error, result?: ApiResponse): void => {
+        handler(event, <ApiContext> {}, (error?: Error | null, result?: ApiResponse): void => {
           if (typeof result === 'undefined') {
             reject('No result was returned by the handler!');
             return;

src/swagger/swagger.service.ts

@@ -31,7 +31,7 @@ export class SwaggerService {
     const version: string = <string> this._env.API_INFO_VERSION;
 
     return this._repo.getRestApiId(stageName, restApiName)
-      .then((restApiId: string) => {
+      .then((restApiId: string | undefined) => {
         if (!restApiId) {
           throw new NotFoundResult(ErrorCode.InvalidName, 'Cannot find the API with the specified name!');
         }

test/index.ts

@@ -13,7 +13,7 @@ export const callSuccess: SuccessCaller = <T>(handler: ApiHandler, pathParameter
       event.pathParameters = pathParameters;
     }
 
-    handler(event, <ApiContext> {}, (error?: Error, result?: ApiResponse): void => {
+    handler(event, <ApiContext> {}, (error?: Error | null, result?: ApiResponse): void => {
       if (typeof result === 'undefined') {
         reject('No result was returned by the handler!');
         return;
@@ -35,7 +35,7 @@ export const callFailure: FailureCaller = (handler: ApiHandler, pathParameters?:
       event.pathParameters = pathParameters;
     }
 
-    handler(event, <ApiContext> {}, (error?: Error, result?: ApiResponse): void => {
+    handler(event, <ApiContext> {}, (error?: Error | null, result?: ApiResponse): void => {
       if (typeof result === 'undefined') {
         reject('No result was returned by the handler!');
         return;