Skip to content

Commit 553f057

Browse files
authored
Fixed printing how many packages will be published when release plan has a release of type none (#30)
1 parent 3922260 commit 553f057

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

index.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,17 @@ import { ValidationError } from "@changesets/errors";
1515
const getReleasePlanMessage = (releasePlan: ReleasePlan | null) => {
1616
if (!releasePlan) return "";
1717

18-
let table = markdownTable([
19-
["Name", "Type"],
20-
...releasePlan.releases
18+
const publishableReleases = releasePlan.releases
2119
.filter(
2220
(
2321
x
2422
): x is ComprehensiveRelease & { type: Exclude<VersionType, "none"> } =>
2523
x.type !== "none"
2624
)
25+
26+
let table = markdownTable([
27+
["Name", "Type"],
28+
...publishableReleases
2729
.map((x) => {
2830
return [
2931
x.name,
@@ -39,15 +41,15 @@ const getReleasePlanMessage = (releasePlan: ReleasePlan | null) => {
3941
return `<details><summary>This PR includes ${
4042
releasePlan.changesets.length
4143
? `changesets to release ${
42-
releasePlan.releases.length === 1
44+
publishableReleases.length === 1
4345
? "1 package"
44-
: `${releasePlan.releases.length} packages`
46+
: `${publishableReleases.length} packages`
4547
}`
4648
: "no changesets"
4749
}</summary>
4850
4951
${
50-
releasePlan.releases.length
52+
publishableReleases.length
5153
? table
5254
: "When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types"
5355
}

0 commit comments

Comments
 (0)