Added encoding detection to the lastChar and firstChar methods.

Martin Brecht-Precht · Martin Brecht-Precht · commit 383cf5217b46 · 2016-08-30T13:52:52.000+02:00
diff --git a/src/StringBuilder.php b/src/StringBuilder.php
@@ -268,7 +268,7 @@ public function charAt($position)
 	 */
 	public function firstChar()
 	{
-		return mb_substr($this->string, 0, 1);
+		return mb_substr($this->string, 0, 1, mb_detect_encoding($this->string));
 	}
 
 	/**
@@ -278,7 +278,7 @@ public function firstChar()
 	 */
 	public function lastChar()
 	{
-		return mb_substr($this->string, -1);
+		return mb_substr($this->string, -1, null, mb_detect_encoding($this->string));
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ public function charAt($position)`
`268`	`268`	`*/`
`269`	`269`	`public function firstChar()`
`270`	`270`	`{`
`271`		`- return mb_substr($this->string, 0, 1);`
	`271`	`+ return mb_substr($this->string, 0, 1, mb_detect_encoding($this->string));`
`272`	`272`	`}`
`273`	`273`
`274`	`274`	`/**`
`@@ -278,7 +278,7 @@ public function firstChar()`
`278`	`278`	`*/`
`279`	`279`	`public function lastChar()`
`280`	`280`	`{`
`281`		`- return mb_substr($this->string, -1);`
	`281`	`+ return mb_substr($this->string, -1, null, mb_detect_encoding($this->string));`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`/**`