Skip to content

Commit eba7ecd

Browse files
committed
WIP
1 parent 3a0861a commit eba7ecd

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed

config/flatfox.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
return [
44

5-
'token' => env('FLATFOX_TOKEN'),
6-
'public_listing_identifier' => env('FLATFOX_PUBLIC_LISTING_IDENTIFIER'),
7-
5+
'timeout' => env('FLATFOX_TIMEOUT', 15),
6+
'caching' => env('FLATFOX_CACHING', 1),
87
];

src/DTO/Listing.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ public function __construct(
6161
public string|null $website_url,
6262
public string|null $live_viewing_url,
6363
public int|null $cover_image,
64-
public null $images,
65-
public null $documents,
66-
public null $agency,
64+
public Collection|null $images,
65+
public Collection|null $documents,
66+
public Agency|null $agency,
6767
public bool $reserved,
6868
public string|null $rent_title,
6969
public int|null $livingspace,
@@ -127,8 +127,8 @@ public static function fromJson(array $data): self
127127
website_url: Arr::get($data, 'website_url'),
128128
live_viewing_url: Arr::get($data, 'live_viewing_url'),
129129
cover_image: Arr::get($data, 'cover_image'),
130-
images: Arr::has($data, 'images') ? self::attributes(Arr::get($data, 'images')) : null,
131-
documents: Arr::has($data, 'documents') ? self::attributes(Arr::get($data, 'documents')) : null,
130+
images: Arr::has($data, 'images') ? self::images(Arr::get($data, 'images')) : null,
131+
documents: Arr::has($data, 'documents') ? self::documents(Arr::get($data, 'documents')) : null,
132132
agency: Arr::has($data, 'agency') ? Agency::fromJson(Arr::get($data, 'agency')) : null,
133133
reserved: Arr::get($data, 'reserved'),
134134
rent_title: Arr::get($data, 'rent_title'),

src/Requests/GetPublicListing.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function createDtoFromResponse(Response $response): mixed
4545
protected function defaultConfig(): array
4646
{
4747
return [
48-
'timeout' => 15,
48+
'timeout' => config('flatfox.caching', 15),
4949
];
5050
}
5151

@@ -56,6 +56,6 @@ public function resolveCacheDriver(): Driver
5656

5757
public function cacheExpiryInSeconds(): int
5858
{
59-
return 1;
59+
return config('flatfox.caching', 1);
6060
}
6161
}

tests/Feature/GetPublicListingTest.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,13 @@
1111
$forge = new FlatfoxConnector();
1212
$request = new GetPublicListing(142, '&expand=documents&expand=images');
1313
$response = $forge->send($request);
14-
15-
ray($response->json());
1614
})
17-
->group('get', 'public-listing');
15+
->group('get', 'public-listing')
16+
->skip();
1817

1918
it('get public listing', function () {
2019
$mockClient = new MockClient([
2120
GetPublicListing::class => MockResponse::fixture('singleServer'),
2221
]);
2322
})
24-
->group('get', 'public-listing')->todo();
23+
->group('get', 'public-listing')->skip();

0 commit comments

Comments
 (0)