PHP7 support (#2)

* Add test for php7 support

* Bump sonar-php-plugin: not latest version, but the most recent with a compatible API and php7 support

Author: filipesperandio

build.gradle

@@ -36,7 +36,7 @@ dependencies {
     compile("com.github.codeclimate:sonar-wrapper:master-SNAPSHOT")
 
     // Plugins
-    compile("org.sonarsource.php:sonar-php-plugin:2.10.0.2087")
+    compile("org.sonarsource.php:sonar-php-plugin:2.11.0.2485")
 
     testCompile("org.assertj:assertj-core:2.8.0")
     testCompile("org.skyscreamer:jsonassert:1.5.0")

fixtures/app/config.json

@@ -1,6 +1,7 @@
 {
   "enabled": true,
   "include_paths": [
-    "main.php"
+    "main.php",
+    "php7_constants.php"
   ]
 }

fixtures/app/php7_constants.php

@@ -0,0 +1,8 @@
+<?php
+class ConstDemo
+{
+    const PUBLIC_CONST_A = 1;
+    public const PUBLIC_CONST_B = 2;
+    protected const PROTECTED_CONST = 3;
+    private const PRIVATE_CONST = 4;
+}

src/test/resources/sanity_check_expected_issues.json

@@ -36,5 +36,24 @@
     "categories": [
       "Bug Risk"
     ]
+  },
+  {
+    "type": "issue",
+    "check_name": "php:S1068",
+    "severity": "major",
+    "description": "Remove this unused \"PRIVATE_CONST\" private field.",
+    "content": {
+      "body": "<p>If a <code>private</code> field is declared but not used in the program, it can be considered dead code and should therefore be removed. This will\nimprove maintainability because developers will not wonder what the variable is used for.</p>\n<h2>Noncompliant Code Example</h2>\n<pre>\nclass MyClass {\n  private $foo = 4;                       //foo is unused\n\n  public function compute($a) {\n    return $a * 4;\n  }\n}\n</pre>\n<h2>Compliant Solution</h2>\n<pre>\nclass MyClass {\n\n  public function compute($a) {\n    return $a * 4;\n  }\n}\n</pre>\n<h2>See</h2>\n<ul>\n  <li> <a href=\"https://www.securecoding.cert.org/confluence/x/SIIyAQ\">CERT, MSC12-CPP.</a> - Detect and remove code that has no effect </li>\n</ul>"
+    },
+    "location": {
+      "path": "php7_constants.php",
+      "lines": {
+        "begin": 7,
+        "end": 7
+      }
+    },
+    "categories": [
+      "Clarity"
+    ]
   }
 ]