Skip to content

Skip "git push" is no screenshot is updated in job "update-cli-screenshots" #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lee-W opened this issue May 22, 2024 · 2 comments · Fixed by #1139
Closed

Skip "git push" is no screenshot is updated in job "update-cli-screenshots" #1138

Lee-W opened this issue May 22, 2024 · 2 comments · Fixed by #1139
Assignees

Comments

@Lee-W
Copy link
Member

Lee-W commented May 22, 2024

Description

- name: Commit and push updated CLI screenshots
should be skipped if nothing is updated in
poetry run python scripts/gen_cli_help_screenshots.py

Steps to reproduce

  1. poetry run python scripts/gen_cli_help_screenshots.py
  2. Run git commit and git push

Current behavior

Blocking documentation generation due to

git commit -m "docs(cli/screenshots): update CLI screenshots" -m "[skip ci]"
git push
failure if there's no screenshot update

Desired behavior

If no screenshot is updated, the CI should just skip the committing and pushing steps.

Screenshots

No response

Environment

Commitizen Version: 3.13.0
Python Version: 3.11.6 (main, Oct 16 2023, 12:18:37) [Clang 15.0.0 (clang-1500.0.40.1)]
Operating System: Darwin

@marcosdotme
Copy link
Contributor

@Lee-W Well, since its a bug related to an feature introduced by me, can I work on it?

@Lee-W
Copy link
Member Author

Lee-W commented May 22, 2024

@Lee-W Well, since its a bug related to an feature introduced by me, can I work on it?

Definitely 🙂 let me assign it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants