Merge pull request #900 from common-workflow-language/actual_streaming_safe_checksums

make the other checksum calculations streaming safe too

Author: mr-c

cwltool/process.py

@@ -976,7 +976,5 @@ def compute_checksums(fs_access, fileobj):
             while contents != b"":
                 checksum.update(contents)
                 contents = f.read(1024 * 1024)
-            f.seek(0, 2)
-            filesize = f.tell()
         fileobj["checksum"] = "sha1$%s" % checksum.hexdigest()
-        fileobj["size"] = filesize
+        fileobj["size"] = fs_access.size(fileobj["location"])

tests/test_deps_env/random-lines/1.0/scripts/random-lines

@@ -30,7 +30,6 @@ def get_random( line_offsets, num_lines ):
 
 
 def __main__():
-    open("/Users/john/moo", "w").write("cow")
     parser = optparse.OptionParser()
     parser.add_option( '-s', '--seed', dest='seed', action='store', type="string", default=None, help='Set the random seed.' )
     (options, args) = parser.parse_args()