Why does binary_stream_sink::flush not flush the underlying ostream?

[ecorm]

I was comparing stream_sink with binary_stream_sink to see what the differences were. I noticed that stream_sink::flush performs stream_ptr_->flush() whereas binary_stream_sink::flush does not.

stream_sink::flush:

jsoncons/include/jsoncons/sink.hpp

Lines 65 to 70 in 40757fa

	void flush()
	{
	stream_ptr_->write(begin_buffer_, buffer_length());
	stream_ptr_->flush();
	p_ = buffer_.data();
	}

binary_stream_sink::flush:

jsoncons/include/jsoncons/sink.hpp

Lines 156 to 160 in 40757fa

	void flush()
	{
	stream_ptr_->write((char*)begin_buffer_, buffer_length());
	p_ = buffer_.data();
	}

Was this intentional, or was in an omission?

[danielaparker]

I can't remember. Off hand I can't think of a reason not to flush it here. It does get flushed when the sink is destroyed.

The only distinguishing feature of binary_stream_sink is that the user interacts with the sink using uint8_t sequences, and the sink writes to the underlying stream assuming char.