Skip to content

Naive Bayes #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfsf9797 opened this issue May 5, 2021 · 3 comments
Closed

Naive Bayes #67

sfsf9797 opened this issue May 5, 2021 · 3 comments
Labels
model request Request for a new model / implementation

Comments

@sfsf9797
Copy link
Contributor

sfsf9797 commented May 5, 2021

Hi, I am thinking about implementing Naive Bayes Methods and make a pull request. But I am unsure about the Unit testing part, Should I compare the performance with the ScikitLearn library?
@ddbourgin ddbourgin added the model request Request for a new model / implementation label May 25, 2021
@rishabh-jain14
Copy link

Issue solved. please refer to the pull request. #75

@rishabh-jain14
Copy link

Also, please let me know the places for improvement in the pull request. I am happy to work on the repository and learn in the best feasible way

@ddbourgin ddbourgin mentioned this issue Sep 23, 2021
Open
@ddbourgin
Copy link
Owner

Closed via #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
model request Request for a new model / implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddbourgin @sfsf9797 @rishabh-jain14