Skip to content

Commit e7dd59f

Browse files
Fixed some types and something small todo in be still.
1 parent 21ee20d commit e7dd59f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

country-service-backend/src/main/java/com/country_service/country_service_backend/client/CountriesNowRestClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111

1212
public interface CountriesNowRestClient {
1313

14-
/* Flux since REST endpoint returns multiple values, even thought its wrapped in Mono */
14+
/* Flux since REST end point returns multiple values, even thought it will be wrapped into the Mono in the end */
1515
Flux<CountryIsoResponseDto> getCountriesWithIsoByGet();
1616

1717
@Deprecated
1818
Mono<String> getCountryWithPopulationByPost(String countryName);
19-
/* Flux since REST endpoint returns multiple values, even thought its wrapped in Mono */
19+
/* Flux since REST end point returns multiple values, even thought it will be wrapped into the Mono in the end */
2020
Flux<CountryPopulationSingleCountResponseDto> getCountyWithPopulationByGet(String countryName);
2121

2222
@Deprecated

country-service-backend/src/main/java/com/country_service/country_service_backend/service/CountriesServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public Mono<Countries> getCountries() {
4848

4949
@Override
5050
public Mono<Country> getInformationAboutCountry(String countryName) {
51-
51+
//TODO(heikki) error throw some right exception if input is incorrect. Wrong country -> error message is "no population for country", its should be no country found to begin with!
5252
Mono<CountryPopulationSingleCountResponseDto> populationMono = countriesNowRestClient.getCountyWithPopulationByGet(countryName).last(); // for latest population from API.
5353
Mono<CountryFlagImageInfoResponseDto> flagMono = countriesNowRestClient.getCountryWithFlagUrlByGet(countryName); // for flag URL from API.
5454
Mono<CountryCapitalInfoResponseDto> capitalMono = countriesNowRestClient.getCountyWithCapitalByGet(countryName); // for getting capital from API.

0 commit comments

Comments
 (0)