test: add more integration tests

Author: devshawn

.codeclimate.yml

@@ -0,0 +1,8 @@
+version: "2"
+checks:
+  method-count:
+    config:
+      threshold: 40
+  similar-code:
+    config:
+      threshold: 60

README.md

@@ -1,5 +1,7 @@
 # kafka-gitops
 
+![Java CI](https://github.com/devshawn/kafka-gitops/workflows/Java%20CI/badge.svg) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](LICENSE)
+
 Manage Apache Kafka topics and ACLs through a desired state file.
 
 <p align="center">

src/main/java/com/devshawn/kafka/gitops/service/ParserService.java

@@ -43,15 +43,15 @@ public DesiredStateFile parseStateFile() {
             DesiredStateFile.Builder builder = new DesiredStateFile.Builder().mergeFrom(desiredStateFile);
             SettingsFiles settingsFiles = desiredStateFile.getSettings().get().getFiles().get();
             if (settingsFiles.getServices().isPresent()) {
-                DesiredStateFile servicesFile = loadServiceFile(settingsFiles.getServices().get());
+                DesiredStateFile servicesFile = loadExternalFile(settingsFiles.getServices().get(), "Services");
                 builder.putAllServices(servicesFile.getServices());
             }
             if (settingsFiles.getTopics().isPresent()) {
-                DesiredStateFile topicsFile = loadTopicsFile(settingsFiles.getTopics().get());
+                DesiredStateFile topicsFile = loadExternalFile(settingsFiles.getTopics().get(), "Topics");
                 builder.putAllTopics(topicsFile.getTopics());
             }
             if (settingsFiles.getUsers().isPresent()) {
-                DesiredStateFile usersFile = loadUsersFile(settingsFiles.getUsers().get());
+                DesiredStateFile usersFile = loadExternalFile(settingsFiles.getUsers().get(), "Users");
                 builder.putAllUsers(usersFile.getUsers());
             }
             return builder.build();
@@ -88,28 +88,12 @@ public DesiredStateFile parseStateFile(File stateFile) {
         }
     }
 
-    private DesiredStateFile loadServiceFile(String servicesFileName) {
-        File servicesFile = getAdditionalFile(servicesFileName);
-        if (!servicesFile.exists()) {
-            throw new ValidationException(String.format("Services file '%s' could not be found.", servicesFileName));
+    private DesiredStateFile loadExternalFile(String fileName, String type) {
+        File externalFile = getAdditionalFile(fileName);
+        if (!externalFile.exists()) {
+            throw new ValidationException(String.format("%s file '%s' could not be found.", type, fileName));
         }
-        return parseStateFile(servicesFile);
-    }
-
-    private DesiredStateFile loadTopicsFile(String topicsFileName) {
-        File topicsFile = getAdditionalFile(topicsFileName);
-        if (!topicsFile.exists()) {
-            throw new ValidationException(String.format("Topics file '%s' could not be found.", topicsFileName));
-        }
-        return parseStateFile(topicsFile);
-    }
-
-    private DesiredStateFile loadUsersFile(String usersFileName) {
-        File usersFile = getAdditionalFile(usersFileName);
-        if (!usersFile.exists()) {
-            throw new ValidationException(String.format("Users file '%s' could not be found.", usersFileName));
-        }
-        return parseStateFile(usersFile);
+        return parseStateFile(externalFile);
     }
 
     private File getAdditionalFile(String fileName) {

src/test/groovy/com/devshawn/kafka/gitops/PlanCommandIntegrationSpec.groovy

@@ -54,7 +54,8 @@ class PlanCommandIntegrationSpec extends Specification {
                 "application-service",
                 "kafka-connect-service",
                 "kafka-streams-service",
-                "topics-and-services"
+                "topics-and-services",
+                "multi-file"
         ]
     }
 
@@ -118,7 +119,31 @@ class PlanCommandIntegrationSpec extends Specification {
         planName << [
                 "invalid-missing-principal",
                 "invalid-topic",
-                "unrecognized-property"
+                "unrecognized-property",
+                "invalid-format"
         ]
     }
+
+    void 'test file that does not exist - #planName'() {
+        setup:
+        ByteArrayOutputStream err = new ByteArrayOutputStream()
+        ByteArrayOutputStream out = new ByteArrayOutputStream()
+        PrintStream oldErr = System.err
+        PrintStream oldOut = System.out
+        System.setErr(new PrintStream(err))
+        System.setOut(new PrintStream(out))
+        MainCommand mainCommand = new MainCommand()
+        CommandLine cmd = new CommandLine(mainCommand)
+
+        when:
+        int exitCode = cmd.execute("-f", "null", "plan")
+
+        then:
+        exitCode == 2
+        out.toString() == TestUtils.getResourceFileContent("plans/null-file-output.txt")
+
+        cleanup:
+        System.setErr(oldErr)
+        System.setOut(oldOut)
+    }
 }

src/test/resources/plans/invalid-format-output.txt

@@ -0,0 +1,3 @@
+Generating execution plan...
+
+[INVALID] Value 'a' is not a valid format for: [partitions] in state file definition: topics -> test-topic

src/test/resources/plans/invalid-format.yaml

@@ -0,0 +1,4 @@
+topics:
+  test-topic:
+    partitions: "a"
+    replication: 3

src/test/resources/plans/multi-file-plan.json

@@ -0,0 +1,55 @@
+{
+    "topicPlans": [
+        {
+            "name": "test-topic",
+            "action": "ADD",
+            "topicDetails": {
+                "partitions": 6,
+                "replication": 1,
+                "configs": {}
+            },
+            "topicConfigPlans": []
+        }
+    ],
+    "aclPlans": [
+        {
+            "name": "test-service-0",
+            "aclDetails": {
+                "name": "test-topic",
+                "type": "TOPIC",
+                "pattern": "LITERAL",
+                "principal": "User:test",
+                "host": "*",
+                "operation": "WRITE",
+                "permission": "ALLOW"
+            },
+            "action": "ADD"
+        },
+        {
+            "name": "test-service-1",
+            "aclDetails": {
+                "name": "another-test-topic",
+                "type": "TOPIC",
+                "pattern": "LITERAL",
+                "principal": "User:test",
+                "host": "*",
+                "operation": "READ",
+                "permission": "ALLOW"
+            },
+            "action": "ADD"
+        },
+        {
+            "name": "test-service-2",
+            "aclDetails": {
+                "name": "test-service",
+                "type": "GROUP",
+                "pattern": "LITERAL",
+                "principal": "User:test",
+                "host": "*",
+                "operation": "READ",
+                "permission": "ALLOW"
+            },
+            "action": "ADD"
+        }
+    ]
+}

src/test/resources/plans/multi-file-services.yaml

@@ -0,0 +1,8 @@
+services:
+  test-service:
+    type: application
+    principal: User:test
+    produces:
+      - test-topic
+    consumes:
+      - another-test-topic

src/test/resources/plans/multi-file-topics.yaml

@@ -0,0 +1,4 @@
+topics:
+  test-topic:
+    partitions: 6
+    replication: 1

src/test/resources/plans/multi-file-users.yaml

@@ -0,0 +1 @@
+users: {}

src/test/resources/plans/multi-file.yaml

@@ -0,0 +1,5 @@
+settings:
+  files:
+    services: multi-file-services.yaml
+    topics: multi-file-topics.yaml
+    users: multi-file-users.yaml

src/test/resources/plans/null-file-output.txt

@@ -0,0 +1,3 @@
+Generating execution plan...
+
+[INVALID] Invalid state file. Unknown error: null (No such file or directory)